[GitHub] [helix] dasahcc commented on issue #516: Implement the propertyStore read endpoint

[GitBox <gi...@apache.org>]

dasahcc commented on issue #516: Implement the propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#issuecomment-557316739
 
 
   > > Why this PR contains customized serializer change? I would suggest to separate the PR. 1 for customized serializer change and another for propertyStore REST.
   > 
   > The property store accessor just re-uses the existing features by the custom serializer and I think it's needed for parsing the content under PropertyStore. The PR is all about property store read api only.
   
   I am confused about that. For propertyStore, it uses ZNRecord. Default serializer should be fine. Why it depends on the customized serializer.
   
   Even we need that, we should separate them out. Have a separate customized serializer first. Let's review that. After that, let's talk about the propertyStore support. Dont merge them together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org