[jira] Commented: (SMXCOMP-55) Add get/setTempFileName methods to DefaultFileMarshaler and use in File/Ftp Sender Endpoints (also deprecate FTP Sender uploadPrefix/Suffix properties)

["Pavlo Fenoga (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/SMXCOMP-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59539#action_59539 ] 

Pavlo Fenoga commented on SMXCOMP-55:
-------------------------------------

We are moving from SMX 3.3.1 to 3.3.2 New SMX version uses File Component 2010.01
Updated FileSender  doesn't work  in compatible way with previous versions.
e.g. when file name is not provided by marshaler sender generates some default file name. Before it was like servicemix-6010698277380584591.xml but with new version of FileSender we have name similar to 127479483812241617tmp
I see strange changes in FileSenderEndpoint.java, rev. 766890, line 90
It is not clear why string 
newFile = File.createTempFile(tempFilePrefix, tempFileSuffix, directory);
was changed to 
newFile = File.createTempFile("" + System.currentTimeMillis(), "tmp", directory);
What was the reason to do so and break compatibility?
It was done in scope of temp file improvements described in this issue but doesn't relate to this at all actually.

> Add get/setTempFileName methods to DefaultFileMarshaler and use in File/Ftp Sender Endpoints (also deprecate FTP Sender uploadPrefix/Suffix properties)
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMXCOMP-55
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-55
>             Project: ServiceMix Components
>          Issue Type: Improvement
>          Components: servicemix-file, servicemix-ftp, servicemix-vfs
>    Affects Versions: 3.2.3
>            Reporter: Ron Gavlin
>            Assignee: Lars Heinemann
>             Fix For: servicemix-file-2009.02, servicemix-ftp-2009.02, servicemix-shared-2009.02, servicemix-vfs-2009.02
>
>         Attachments: servicemix-file.patch, servicemix-ftp.patch, servicemix-vfs.patch, SMXCOMP-55.patch, utils.patch
>
>
> The Ftp Sender Endpoint currently has properties uploadPrefix and uploadSuffix to allow someone to create a file with a specific "temp" prefix/suffix and then rename the file when it is finished being written. This would also be useful in the File Sender Endpoint to support scenarios where an ftp client is attempting to access a file sender directory and knows to avoid reading files with certain "temp" prefixes.
> Since the DefaultFileMarshaler is used by both endpoints, I suggest that get/setTempFileName methods be added to the DefaultFileMarshaler and the endpoints updated to leverage these methods. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.