You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/07 16:51:34 UTC

[GitHub] [airflow] alexInhert opened a new issue #17487: Make gantt view to show also retries

alexInhert opened a new issue #17487:
URL: https://github.com/apache/airflow/issues/17487


   
   **Description**
   
   Currently Gantt View shows only the last successful task retry.
   This means that if we have t1 >> t2 >> t3
   if we had:
   t1 started on 08:00 finished 09:00
   t2  1st retry started 09:01 failed on 13:00
   t2 2nd retry started on 13:02 finished on 15:00
   t3 started on 15:01 finished on 15:02
   
   What the gantt view will show us is 
   t1 08:00-09:00
   t2 13:02-15:00
   t3 15:01-15:02
   
   This makes it really hard to understand what really happen because it doesn't show what really happened.
   This is very annoying for DAGs with so many tasks because you can't tell if the problem is due to tasks not being scheduled or this is something else. I understand the value of the current display but maybe it can add some toggle to consider also all the task instances?
   
   **Use case / motivation**
   
   The gantt somehow should show the actual information.
   
   **Are you willing to submit a PR?**
   
   Don't have the skills for that.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ShakaibKhan commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
ShakaibKhan commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-950417646


   A little confused as to what is being asked for as it look like task retries are shown in the gantt view. So is the focus of this issue to have a toggle to choose which task history to display?
   ![Screen Shot 2021-10-24 at 7 31 37 PM](https://user-images.githubusercontent.com/10384742/138617315-599fb77b-9241-4beb-a464-50cd6eaf28b8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-928910683


   Sweet. Just assigned you. Feel free to reach out if you need anything!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] alexInhert commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
alexInhert commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-982907425


   @ShakaibKhan @bbovenzi  see this example
   ![Screen Shot 2021-11-30 at 20 27 28](https://user-images.githubusercontent.com/62940116/144106608-e5ca04ba-6c36-429c-b6f4-2610de9f7780.png)
   
   
   As you can see there is significant gap between the tasks. When you hover over the task you see it is the 2nd retry. If going into the log it shown that the first retry run for the duration of the purple rectangle.
   My request is to add the purple rectangle. I want to see also the retries in the gantt without it - the Gantt just looks like the scheduler didn't schedule anything during this time which is incorrect view of what really happened.
   I think the current setup is useful I'm asking for a way to enrich it also with the retries of the tasks to show the full picture.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ShakaibKhan commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
ShakaibKhan commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-985077443


   @alexInhert make sense to me and agree that retries should be shown; could you please share the DAG you used to make the above gantt chart


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ShakaibKhan commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
ShakaibKhan commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-928564345


   I would like to try implementing this
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ShakaibKhan commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
ShakaibKhan commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-1016518807


   Sorry I do not think I can take on this issue at this time. Unassigning to myself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-928910683


   Sweet. Just assigned you. Feel free to reach out if you need anything!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ShakaibKhan commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
ShakaibKhan commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-928564345


   I would like to try implementing this
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #17487: Make gantt view to show also retries

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17487:
URL: https://github.com/apache/airflow/issues/17487#issuecomment-926516773


   I've been thinking about how to make the gantt view more useful (I think it has a lot of potential). Showing the full state history of a task instance would be a great part of that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org