You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignasi <ig...@gmail.com> on 2013/08/21 16:07:45 UTC
Review dashboard
Hi!
I just deployed to Heroku a dashboard to see the opened pull requests
[1]. Now that we have many opened pull requests it can help having a
global vision of all of them, which ones pass the build, which ones
are old ones, and which ones have some +1.
They can also be viewed in Github, but this helps identifying the ones
passing the build. It is very very simple, a little buggy, and has
lots of room for improvement (code is here [2] and config here [3]),
but it serves its purpose (at least it saves time to me :D).
Feel free to use it!
I.
[1] http://jclouds-pulls.herokuapp.com/ (the app can also be started locally)
[2] https://github.com/nacx/code-review-dashboard/tree/jclouds
[3] https://github.com/nacx/code-review-dashboard/blob/jclouds/config.py
Re: Review dashboard
Posted by Ignasi <ig...@gmail.com>.
Yes, having it deployed there would be much better. I'll move it to
java if I have a little time to :)
BTW, I just re-deployed the dashboard to highlight in green the PRs
where the current user has posted comments, to make it easier to
identity the PRs where one has participated.
On 21 August 2013 17:52, Andrew Phillips <ap...@qrmedia.com> wrote:
>> They can also be viewed in Github, but this helps identifying the ones
>> passing the build. It is very very simple, a little buggy, and has
>> lots of room for improvement (code is here [2] and config here [3]),
>> but it serves its purpose (at least it saves time to me :D).
>
>
> Very cool! I notice it's a Python app...should be using a jclouds-github
> provider, surely? ;-))
>
> I'll see if we can get something set up in DEV@cloud and RUN@cloud for this,
> too...seems like this is closely tied to our CI stuff.
>
> Thanks!!
>
> ap
Re: Review dashboard
Posted by Andrew Phillips <ap...@qrmedia.com>.
> They can also be viewed in Github, but this helps identifying the ones
> passing the build. It is very very simple, a little buggy, and has
> lots of room for improvement (code is here [2] and config here [3]),
> but it serves its purpose (at least it saves time to me :D).
Very cool! I notice it's a Python app...should be using a
jclouds-github provider, surely? ;-))
I'll see if we can get something set up in DEV@cloud and RUN@cloud for
this, too...seems like this is closely tied to our CI stuff.
Thanks!!
ap
Re: Review dashboard
Posted by Andrew Phillips <ap...@qrmedia.com>.
> I just moved the fork of the dashboard to the jclouds organization in
> github so it is more accessible and everyone has right on it!
Great, thanks!
ap
Re: Review dashboard
Posted by Ignasi <ig...@gmail.com>.
I just moved the fork of the dashboard to the jclouds organization in
github so it is more accessible and everyone has right on it!
On 29 August 2013 23:43, Ignasi <ig...@gmail.com> wrote:
> Sure! I've been quite busy this week, but I hope to have a chance to add it!
>
> On 26 August 2013 16:18, Andrew Phillips <ap...@qrmedia.com> wrote:
>>> The left column now shows the PRs that still don't have CI comments or
>>> that are currently failing the build (last failure is more recent than
>>> last ok); the middle column shows the PRs where the build is OK (last
>>> success is more recent than last failure), and the right column shows
>>> those PRs that someone has +1'ed (this just looks for a +1 in the
>>> comments, so this could be improved a bit).
>>
>>
>> Thanks for the updates! One quick comment: perhaps a mouseover or
>> explanation of what each of the columns mean, in case a viewer hasn't read
>> this email? ;-)
>>
>> ap
Re: Review dashboard
Posted by Ignasi <ig...@gmail.com>.
Sure! I've been quite busy this week, but I hope to have a chance to add it!
On 26 August 2013 16:18, Andrew Phillips <ap...@qrmedia.com> wrote:
>> The left column now shows the PRs that still don't have CI comments or
>> that are currently failing the build (last failure is more recent than
>> last ok); the middle column shows the PRs where the build is OK (last
>> success is more recent than last failure), and the right column shows
>> those PRs that someone has +1'ed (this just looks for a +1 in the
>> comments, so this could be improved a bit).
>
>
> Thanks for the updates! One quick comment: perhaps a mouseover or
> explanation of what each of the columns mean, in case a viewer hasn't read
> this email? ;-)
>
> ap
Re: Review dashboard
Posted by Andrew Phillips <ap...@qrmedia.com>.
> The left column now shows the PRs that still don't have CI comments or
> that are currently failing the build (last failure is more recent than
> last ok); the middle column shows the PRs where the build is OK (last
> success is more recent than last failure), and the right column shows
> those PRs that someone has +1'ed (this just looks for a +1 in the
> comments, so this could be improved a bit).
Thanks for the updates! One quick comment: perhaps a mouseover or
explanation of what each of the columns mean, in case a viewer hasn't
read this email? ;-)
ap
Re: Review dashboard
Posted by Ignasi <ig...@gmail.com>.
I just re-deployed the dashboard with the mentioned changes.
The left column now shows the PRs that still don't have CI comments or
that are currently failing the build (last failure is more recent than
last ok); the middle column shows the PRs where the build is OK (last
success is more recent than last failure), and the right column shows
those PRs that someone has +1'ed (this just looks for a +1 in the
comments, so this could be improved a bit).
I've refactored a bit the code and now all the customization is done
here [1]. Also added a couple comments, to show what each method does,
but it shouldn't be difficult to read! :)
[1] https://github.com/nacx/code-review-dashboard/blob/jclouds/plugins/jclouds.py
On 26 August 2013 08:37, Ignasi <ig...@gmail.com> wrote:
> Currently it just counts the success/failures without taking into account
> the comment date (which sucks :)).
>
> I have a couple changes in progress to make the dashboard more customizable
> that I plan to upload this afternoon. I'll fix the jenkins counters and try
> to have the new version with all the changes deployed by then!
>
> El 24/08/2013 20:45, "Andrew Phillips" <ap...@qrmedia.com> escribió:
>
>>> global vision of all of them, which ones pass the build, which ones
>>> are old ones, and which ones have some +1.
>>
>>
>> What's the criterion for "Jenkins Happy", by the way? The PRs listed seem
>> to have at least one successful build (from BuildHive? DEV@cloud?), but also
>> some failures:
>>
>> jclouds JCLOUDS-251: Swift: Delete chunks when deleting a multipart blob
>> (frankoid)
>> 0 likes / 52 comments / 0 days old
>> 22 success / 2 failures
>>
>> Most in the Need More Work column have at least one failure (some
>> successes, too), but some look like they should't be there?
>>
>> jclouds-karaf [JCLOUDS-225] Configured itests to use the generated repo.
>> (iocanel)
>> 0 likes / 16 comments / 18 days old
>> 1 success / 0 failures
>>
>> Or is "Need More Work" something like "can't be built"?
>>
>> Thanks!
>>
>> ap
Re: Review dashboard
Posted by Ignasi <ig...@gmail.com>.
Currently it just counts the success/failures without taking into account
the comment date (which sucks :)).
I have a couple changes in progress to make the dashboard more customizable
that I plan to upload this afternoon. I'll fix the jenkins counters and try
to have the new version with all the changes deployed by then!
El 24/08/2013 20:45, "Andrew Phillips" <ap...@qrmedia.com> escribió:
> global vision of all of them, which ones pass the build, which ones
>> are old ones, and which ones have some +1.
>>
>
> What's the criterion for "Jenkins Happy", by the way? The PRs listed seem
> to have at least one successful build (from BuildHive? DEV@cloud?), but
> also some failures:
>
> jclouds JCLOUDS-251: Swift: Delete chunks when deleting a multipart blob
> (frankoid)
> 0 likes / 52 comments / 0 days old
> 22 success / 2 failures
>
> Most in the Need More Work column have at least one failure (some
> successes, too), but some look like they should't be there?
>
> jclouds-karaf [JCLOUDS-225] Configured itests to use the generated repo.
> (iocanel)
> 0 likes / 16 comments / 18 days old
> 1 success / 0 failures
>
> Or is "Need More Work" something like "can't be built"?
>
> Thanks!
>
> ap
>
Re: Review dashboard
Posted by Andrew Phillips <ap...@qrmedia.com>.
> global vision of all of them, which ones pass the build, which ones
> are old ones, and which ones have some +1.
What's the criterion for "Jenkins Happy", by the way? The PRs listed
seem to have at least one successful build (from BuildHive?
DEV@cloud?), but also some failures:
jclouds JCLOUDS-251: Swift: Delete chunks when deleting a multipart
blob (frankoid)
0 likes / 52 comments / 0 days old
22 success / 2 failures
Most in the Need More Work column have at least one failure (some
successes, too), but some look like they should't be there?
jclouds-karaf [JCLOUDS-225] Configured itests to use the generated
repo. (iocanel)
0 likes / 16 comments / 18 days old
1 success / 0 failures
Or is "Need More Work" something like "can't be built"?
Thanks!
ap