You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/06/30 08:07:47 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9655: libs/libc/aio: adjust the flags determination method

xiaoxiang781216 commented on code in PR #9655:
URL: https://github.com/apache/nuttx/pull/9655#discussion_r1247570591


##########
fs/aio/aio_write.c:
##########
@@ -277,7 +277,7 @@ int aio_write(FAR struct aiocb *aiocbp)
    */
 
   int flags = fcntl(aiocbp->aio_fildes, F_GETFL);

Review Comment:
   flags need move to the begin of function to conform to c89 standard



##########
fs/aio/aio_write.c:
##########
@@ -277,7 +277,7 @@ int aio_write(FAR struct aiocb *aiocbp)
    */
 
   int flags = fcntl(aiocbp->aio_fildes, F_GETFL);

Review Comment:
   flags need move to the begin of function to conform to c89 standard, @extinguish 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org