You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 16:14:33 UTC

[GitHub] [incubator-superset] nikolagigic commented on a change in pull request #12200: chore: Replace Well componenet with Card component

nikolagigic commented on a change in pull request #12200:
URL: https://github.com/apache/incubator-superset/pull/12200#discussion_r551414572



##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -261,7 +262,11 @@ StackedField.propTypes = {
 };
 
 function FormContainer({ children }) {
-  return <Well style={{ marginTop: 20 }}>{children}</Well>;
+  return (
+    <Card style={{ marginTop: 20 }} bodyStyle={{ padding: 15 }}>

Review comment:
       There 2 cases of **Card** component where one requires different styling than the other. Default **Card** styling is in the Emotion already




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org