You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2017/08/19 11:57:12 UTC

svn commit: r1805504 - /maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java

Author: rfscholte
Date: Sat Aug 19 11:57:11 2017
New Revision: 1805504

URL: http://svn.apache.org/viewvc?rev=1805504&view=rev
Log:
[MSHADE-257] Bad zero length source jars published by 3rd parties cause source jar creation to fail.

Modified:
    maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java

Modified: maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java?rev=1805504&r1=1805503&r2=1805504&view=diff
==============================================================================
--- maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java (original)
+++ maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java Sat Aug 19 11:57:11 2017
@@ -627,7 +627,14 @@ public class ShadeMojo
                 File file = resolveArtifactSources( artifact );
                 if ( file != null )
                 {
-                    sourceArtifacts.add( file );
+                    if ( file.length() > 0 )
+                    {
+                        sourceArtifacts.add( file );
+                    }
+                    else
+                    {
+                        getLog().warn( "Skipping empty source jar " + artifact.getId() + "." );
+                    }
                 }
             }
         }