You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2021/06/20 20:08:41 UTC
[GitHub] [openoffice] ardovm edited a comment on pull request #133: graphite: remove the -Werror option from debug builds
ardovm edited a comment on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285
The first two warnings are IMHO bugs. The first one is a function parameter type `bool` instead of `bool&` and the second is a mixup of return values in a `switch` statement.
Others are linked to assertions not being compiled (although we are requesting a debug build). Some others are unused variables that are explicitly marked `TODO` in the code.
I stopped after checking the first four warnings.
I suggest we allow this PR through so that at least the source becomes compilable again. Then we could have a longer term plan for the replacement of the graphite module with... whatever is better today.
For what it's worth, both the [SourceForge project page](http://silgraphite.sourceforge.net) and [www.sil.org](https://software.sil.org/products/#supported) refer to http://graphite.sil.org that does not seem to exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [GitHub] [openoffice] ardovm edited a comment on pull request
#133: graphite: remove the -Werror option from debug builds
Posted by Don Lewis <tr...@apache.org>.
On 20 Jun, Pedro Lino wrote:
> Hi Arrigo, all
>
> Development seems to be quite live at
> https://github.com/silnrsi/graphite
We are using SIL Graphite, http://silgraphite.sourceforge.net/
Looking at the Graphite technical overview page mentioned here:
https://github.com/silnrsi/graphite/blob/master/README.md
(https://scripts.sil.org/cms/scripts/page.php?site_id=projects&item_id=graphite_techAbout)
under "Graphite engine implementations":
There are two existing implementations of the Graphite engine. The
original engine is packaged under the name "SilGraphite"; the initial
implementation was done in 2000. The Graphite2 engine implementation
began in 2010.
The SilGraphite engine is currently used by OpenOffice, XeTeX,
FieldWorks, and WorldPad. It includes some features not included in
Graphite2, but is considerably slower. Graphite2 represents a
significant (10x) optimization in terms of speed and greatly improved
robustness, but does not include a few features such a ligature
component handling and cross-line-boundary contextualization.
Graphite2 is used by LibreOffice and Firefox.
The two engines support different APIs. The Graphite2 API was
specifically developed to be more compatible with the approach to text
layout used by most commercial software. See the application
development page for API documentation.
Graphite2 would be better, is currently supported, and Libreoffice
switched to it quite a while ago, but it is not a drop-in replacement.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [GitHub] [openoffice] ardovm edited a comment on pull request
#133: graphite: remove the -Werror option from debug builds
Posted by Pedro Lino <pe...@mailbox.org.INVALID>.
Hi Arrigo, all
Development seems to be quite live at
https://github.com/silnrsi/graphite
Regards,
Pedro
> On 06/20/2021 9:08 PM GitBox <gi...@apache.org> wrote:
>
>
> ardovm edited a comment on pull request #133:
> URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285
>
>
> The first two warnings are IMHO bugs. The first one is a function parameter type `bool` instead of `bool&` and the second is a mixup of return values in a `switch` statement.
>
> Others are linked to assertions not being compiled (although we are requesting a debug build). Some others are unused variables that are explicitly marked `TODO` in the code.
>
> I stopped after checking the first four warnings.
>
> I suggest we allow this PR through so that at least the source becomes compilable again. Then we could have a longer term plan for the replacement of the graphite module with... whatever is better today.
>
> For what it's worth, both the [SourceForge project page](http://silgraphite.sourceforge.net) and [www.sil.org](https://software.sil.org/products/#supported) refer to http://graphite.sil.org that does not seem to exist.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org