You are viewing a plain text version of this content. The canonical link for it is here.

Posted to soap-dev@ws.apache.org by yellapragada rajasekhar <ra...@yahoo.com> on 2002/07/03 19:17:46 UTC

Re: [PATCH]Changes to Apache SOAP 2.2 (SAXParser)

 Scott, 
Sorry It took so long to reply.  Anyway I have  generated patch for two files org.apache.soap.rpc.Call  and org.apache.soap.util.xml.DOMUtils,  these files are attached to the mail. And  here is the patch file
diff -r xml-soap/java/src/org/apache/soap/rpc/Call.java /home/rgc/rajfix/xml-soap/java/src/org/apache/soap/rpc/Call.java
76a77,84
> import javax.xml.transform.dom.DOMResult; // JAXP
> import javax.xml.transform.sax.SAXSource; // JAXP
> import javax.xml.transform.TransformerFactory; // JAXP
> import javax.xml.transform.Transformer; // JAXP
> import javax.xml.transform.dom.DOMSource; // JAXP
> import javax.xml.transform.stream.StreamResult; // JAXP
> 
> 
215,216c223,243
<       Document respDoc =
<         xdb.parse(new InputSource(new StringReader(payloadStr)));
---
>       Document respDoc = null;
> // author Raj Yellapragada
>   // Here I have generated SAX document instead of DOM document using Transformation functions in 
>   //  JAXP tools. This is way faster than DOM parser (xdb).   
> //    Document respDoc =
> //        xdb.parse(new InputSource(new StringReader(payloadStr)));
> //     Document document = null;
>  try
>  {
> 
>   DOMResult output = new DOMResult();
>   TransformerFactory xformFactory = TransformerFactory.newInstance();
>   Transformer idTransform = xformFactory.newTransformer();
>   idTransform.transform(new SAXSource(new InputSource(new StringReader(payloadStr))), output);
>   respDoc = (Document) output.getNode();
>  }
>  catch(Exception e)
>  {
>  System.out.println("Error in Transformation of DOM Document to Sax Document  " + e);
>  }
>  
234d260
< 
248,253c274,279
<     catch (SAXException e)
<     {
<       throw new SOAPException(Constants.FAULT_CODE_CLIENT,
<                               "Parsing error, response was:\n" +e.getMessage(),
<          e);
<     }
---
> //    catch (SAXException e)
> //    {
> //      throw new SOAPException(Constants.FAULT_CODE_CLIENT,
> //                              "Parsing error, response was:\n" +e.getMessage(),
> //         e);
> //    }
diff -r xml-soap/java/src/org/apache/soap/util/xml/DOMUtils.java /home/rgc/rajfix/xml-soap/java/src/org/apache/soap/util/xml/DOMUtils.java
70c70
<   private static String NS_URI_XMLNS = "http://www.w3.org/2000/xmlns/";
---
>    private static String NS_URI_XMLNS = "http://www.w3.org/2000/xmlns/";
106d105
< 
249a249
>  
252,255c252
<       Element tempEl = (Element) tempNode;
<       String namespaceURI = (prefix == null)
<                             ? getAttribute (tempEl, "xmlns")
<                             : getAttributeNS (tempEl, NS_URI_XMLNS, prefix);
---
>      Element tempEl = (Element) tempNode;
257,264c254,276
<       if (namespaceURI != null)
<       {
<         return namespaceURI;
<       }
<       else
<       {
<         tempNode = tempEl.getParentNode ();
<       }
---
>   String namespaceURI ;
>   
>   try
>   {
>       namespaceURI  = (prefix == null)
>                            ? getAttribute (tempEl, "xmlns")
>                            : getAttributeNS (tempEl, NS_URI_XMLNS, prefix);
>   }
>  // Raj Yellapragada Here I am checking for NullPointerException and if it is I am using 
>  // Element getattribute method to get to namespaceURI.  
>   catch(java.lang.NullPointerException e)
>   {
>    namespaceURI = tempEl.getAttribute("xmlns:" + prefix);
>   }
>      if (namespaceURI != null)
>      {
> 
>         return namespaceURI;
>      }
>      else
>      {
>        tempNode = tempEl.getParentNode ();
>      }
266c278
< 
---
>     

 
  Scott Nichol <sc...@yahoo.com> wrote: Raj,

Are you still interested in contributing this code?

Scott Nichol

--- yellapragada rajasekhar wrote:
> 
> Hi , 
> 
> My Name is Raj . I work for Insurance Company in
> Scottsdale. Recently 
> my company asked me to look into web services. I
> started downloading 
> SOAP stuff from apache site, I wrote small programs
> every thing works 
> great. But when I really started doing prototype of
> an existing application 
> , it doesn't seem to be working right. Like if Data
> over the wire from 
> Database to Tomcat/SOAP server to Browser is minimal
> then it 
> takes few seconds to process, but if data is huge (>
> 300 Kb) then it really 
> slows down. Then I started digging into your code, I
> found couple of 
> things I can change like you guys are using DOM
> Parser which is Memory 
> intensive , So started changing your code to use
> SAXParser and also I need 
> to changing couple of things in your DOMUtils code
> too. So now it works 
> very fast like in seconds I can see output. So I
> would like share my 
> code and see what you guys think , also wants to
> contribute to 
> development. Not sure how to proceed can some body
> help me on this... 
> 
> 
> 
> Thanks,
> Raj 
> 
> 
> 
> 
> 
> Raja Sekhar.Y
Software Eng.

> 
> 
> ---------------------------------
> Do You Yahoo!?
> LAUNCH - Your Yahoo! Music Experience


__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com

--
To unsubscribe, e-mail: 
For additional commands, e-mail: 


Raja Sekhar.Y<BR>Software Eng.<BR>


---------------------------------
Do You Yahoo!?
New! SBC Yahoo! Dial - 1st Month Free & unlimited access

Re: [PATCH]Changes to Apache SOAP 2.2 (SAXParser)

Posted by yellapragada rajasekhar <ra...@yahoo.com>.

Thanks Scott. To answer your questions I am using Xalan 2.2 and  have tested the changes for Pay loads around  50 Kb - 300 kb . It works great in my environment using Tomcat 3.2.1 . Also I made same changes to WebSphere 4.1 Soap distribution, its work there too. 
 
Let me know if you need more info about my environment.
Thanks,
Raj.
 Scott Nichol wrote:Raj,

In case you missed it, I committed a variation of your changes last night.
The biggest different is that the DocumentBuilder method is still there and
is the default, but the method to use can be specified for each Call. I
want to run some tests to understand the performance impact in various
scenarios.

Scott Nichol

----- Original Message -----
From: "Scott Nichol" 
To: 
Sent: Wednesday, July 24, 2002 5:58 PM
Subject: Re: [PATCH]Changes to Apache SOAP 2.2 (SAXParser)


> Raj,
>
> I am working on integrating your changes into the current CVS code, but I
> have had some problems while testing. I am using Xalan 2.3.1. I am
finding
> that, at least for small payloads, using the SAXSource -> DOMResult
> transform takes longer than using the DOM Parser. I am also getting a
SOAP
> fault on the client when running the addressbook sample.
>
> What parser/transformer were you using? Were you testing with small or
> large payloads?
>
> Scott Nichol
>
> ----- Original Message -----
> From: "yellapragada rajasekhar" 
> To: 
> Sent: Wednesday, July 03, 2002 1:17 PM
> Subject: Re: [PATCH]Changes to Apache SOAP 2.2 (SAXParser)
>
>
> >
> > Scott,
> > Sorry It took so long to reply. Anyway I have generated patch for two
> files org.apache.soap.rpc.Call and org.apache.soap.util.xml.DOMUtils,
> these files are attached to the mail. And here is the patch file
> > diff -r xml-soap/java/src/org/apache/soap/rpc/Call.java
> /home/rgc/rajfix/xml-soap/java/src/org/apache/soap/rpc/Call.java
> > 76a77,84
> > > import javax.xml.transform.dom.DOMResult; // JAXP
> > > import javax.xml.transform.sax.SAXSource; // JAXP
> > > import javax.xml.transform.TransformerFactory; // JAXP
> > > import javax.xml.transform.Transformer; // JAXP
> > > import javax.xml.transform.dom.DOMSource; // JAXP
> > > import javax.xml.transform.stream.StreamResult; // JAXP
> > >
> > >
> > 215,216c223,243
> > < Document respDoc =
> > < xdb.parse(new InputSource(new StringReader(payloadStr)));
> > ---
> > > Document respDoc = null;
> > > // author Raj Yellapragada
> > > // Here I have generated SAX document instead of DOM document using
> Transformation functions in
> > > // JAXP tools. This is way faster than DOM parser (xdb).
> > > // Document respDoc =
> > > // xdb.parse(new InputSource(new StringReader(payloadStr)));
> > > // Document document = null;
> > > try
> > > {
> > >
> > > DOMResult output = new DOMResult();
> > > TransformerFactory xformFactory = TransformerFactory.newInstance();
> > > Transformer idTransform = xformFactory.newTransformer();
> > > idTransform.transform(new SAXSource(new InputSource(new
> StringReader(payloadStr))), output);
> > > respDoc = (Document) output.getNode();
> > > }
> > > catch(Exception e)
> > > {
> > > System.out.println("Error in Transformation of DOM Document to Sax
> Document " + e);
> > > }
> > >
> > 234d260
> > <
> > 248,253c274,279
> > < catch (SAXException e)
> > < {
> > < throw new SOAPException(Constants.FAULT_CODE_CLIENT,
> > < "Parsing error, response was:\n"
> +e.getMessage(),
> > < e);
> > < }
> > ---
> > > // catch (SAXException e)
> > > // {
> > > // throw new SOAPException(Constants.FAULT_CODE_CLIENT,
> > > // "Parsing error, response was:\n"
> +e.getMessage(),
> > > // e);
> > > // }
> > diff -r xml-soap/java/src/org/apache/soap/util/xml/DOMUtils.java
> /home/rgc/rajfix/xml-soap/java/src/org/apache/soap/util/xml/DOMUtils.java
> > 70c70
> > < private static String NS_URI_XMLNS =
"http://www.w3.org/2000/xmlns/";
> > ---
> > > private static String NS_URI_XMLNS =
"http://www.w3.org/2000/xmlns/";
> > 106d105
> > <
> > 249a249
> > >
> > 252,255c252
> > < Element tempEl = (Element) tempNode;
> > < String namespaceURI = (prefix == null)
> > < ? getAttribute (tempEl, "xmlns")
> > < : getAttributeNS (tempEl, NS_URI_XMLNS,
> prefix);
> > ---
> > > Element tempEl = (Element) tempNode;
> > 257,264c254,276
> > < if (namespaceURI != null)
> > < {
> > < return namespaceURI;
> > < }
> > < else
> > < {
> > < tempNode = tempEl.getParentNode ();
> > < }
> > ---
> > > String namespaceURI ;
> > >
> > > try
> > > {
> > > namespaceURI = (prefix == null)
> > > ? getAttribute (tempEl, "xmlns")
> > > : getAttributeNS (tempEl, NS_URI_XMLNS,
> prefix);
> > > }
> > > // Raj Yellapragada Here I am checking for NullPointerException and
if
> it is I am using
> > > // Element getattribute method to get to namespaceURI.
> > > catch(java.lang.NullPointerException e)
> > > {
> > > namespaceURI = tempEl.getAttribute("xmlns:" + prefix);
> > > }
> > > if (namespaceURI != null)
> > > {
> > >
> > > return namespaceURI;
> > > }
> > > else
> > > {
> > > tempNode = tempEl.getParentNode ();
> > > }
> > 266c278
> > <
> > ---
> > >
> >
> >
> > Scott Nichol wrote: Raj,
> >
> > Are you still interested in contributing this code?
> >
> > Scott Nichol
> >
> > --- yellapragada rajasekhar wrote:
> > >
> > > Hi ,
> > >
> > > My Name is Raj . I work for Insurance Company in
> > > Scottsdale. Recently
> > > my company asked me to look into web services. I
> > > started downloading
> > > SOAP stuff from apache site, I wrote small programs
> > > every thing works
> > > great. But when I really started doing prototype of
> > > an existing application
> > > , it doesn't seem to be working right. Like if Data
> > > over the wire from
> > > Database to Tomcat/SOAP server to Browser is minimal
> > > then it
> > > takes few seconds to process, but if data is huge (>
> > > 300 Kb) then it really
> > > slows down. Then I started digging into your code, I
> > > found couple of
> > > things I can change like you guys are using DOM
> > > Parser which is Memory
> > > intensive , So started changing your code to use
> > > SAXParser and also I need
> > > to changing couple of things in your DOMUtils code
> > > too. So now it works
> > > very fast like in seconds I can see output. So I
> > > would like share my
> > > code and see what you guys think , also wants to
> > > contribute to
> > > development. Not sure how to proceed can some body
> > > help me on this...
> > >
> > >
> > >
> > > Thanks,
> > > Raj
> > >
> > >
> > >
> > >
> > >
> > > Raja Sekhar.Y
> > Software Eng.
> >
> > >
> > >
> > > ---------------------------------
> > > Do You Yahoo!?
> > > LAUNCH - Your Yahoo! Music Experience
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! - Official partner of 2002 FIFA World Cup
> > http://fifaworldcup.yahoo.com
> >
> > --
> > To unsubscribe, e-mail:
> > For additional commands, e-mail:
> >
> >
> > Raja Sekhar.Y
Software Eng.

> >
> >
> > ---------------------------------
> > Do You Yahoo!?
> > New! SBC Yahoo! Dial - 1st Month Free & unlimited access
>
>
> --------------------------------------------------------------------------
--
> ----
>
>
> > --
> > To unsubscribe, e-mail: 
> > For additional commands, e-mail: 
>
>
> --
> To unsubscribe, e-mail: 
> For additional commands, e-mail: 
>
>


--
To unsubscribe, e-mail: 
For additional commands, e-mail: 


Raja Sekhar.Y<BR>Software Eng.<BR>


---------------------------------
Do You Yahoo!?
Yahoo! Health - Feel better, live better