You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/05/19 21:29:19 UTC
[kudu-CR] KUDU-2022 Fix nullptr access at GetLocalNetworks.
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6932
Change subject: KUDU-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
KUDU-2022 Fix nullptr access at GetLocalNetworks.
GetLocalNetworks accesses member with nullptr when retrieves
local network interfaces, as both ifaddrs.ifa_addr and
ifaddrs.ifa_netmask fields can contain null pointer. This
patch checks if either of these fields is null before
accessing.
Change-Id: I99d308a48450a25a103afef08b6dcdc557c61f08
---
M src/kudu/util/net/net_util.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/6932/1
--
To view, visit http://gerrit.cloudera.org:8080/6932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99d308a48450a25a103afef08b6dcdc557c61f08
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
KUDU-2022 Fix nullptr access at GetLocalNetworks.
GetLocalNetworks accesses member with nullptr when retrieves
local network interfaces, as both ifaddrs.ifa_addr and
ifaddrs.ifa_netmask fields can contain null pointer. This
patch checks if either of these fields is null before
accessing.
Change-Id: I99d308a48450a25a103afef08b6dcdc557c61f08
Reviewed-on: http://gerrit.cloudera.org:8080/6932
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/net/net_util.cc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99d308a48450a25a103afef08b6dcdc557c61f08
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2022 Fix nullptr access at GetLocalNetworks.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2022 Fix nullptr access at GetLocalNetworks.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99d308a48450a25a103afef08b6dcdc557c61f08
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No