[GitHub] [arrow-datafusion] alamb commented on pull request #5982: feat: support month and year interval for date_bin on constant data

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #5982:
URL: https://github.com/apache/arrow-datafusion/pull/5982#issuecomment-1507460531

   > The month interval for array input was converted into ScalarValue::IntervalDayTime (days) somewhere. My next PR is to find that place and convert month interval into ScalarValue::IntervalMonthDayNano instead. I think if I do that, they will automatically work with this code
   
   
   I suspect the code that is do this is the coercion to the type signature defined here:
   
   https://github.com/apache/arrow-datafusion/blob/1646bf6aae1e568e38c5a43e9a44c34e26222341/datafusion/expr/src/function.rs#L474-L494
   
   I think you could move the `Interval(MonthDayNano)` signatures above the `Interval(DayTime)` ones


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org