You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/09 21:59:30 UTC

[GitHub] [cloudstack] ggoodrich-ipp opened a new pull request #4137: Adding VPN options for IKE version and IKE split connections.

ggoodrich-ipp opened a new pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137


   ## Description
   <!--- Describe your changes in detail -->
   IKE version allows selecting ike (autoselect), ikev1, or ikev2.
   Split connections gives an option of separating the first right subnet from the rest, and kicking out individual statements for each right subnet for better cross-compatibility.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Fixes: #3138 
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   We have been running this code in our production cloud for some months. Prior to this change, whenever an update was made to an existing customer gateway, it was wiping out the manual changes made to the configurations to split these out so that the gateway worked properly. Now, this code allows for these to be split into their own connections via the UI.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-698768823


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788748833


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-ubuntu) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] soreana commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
soreana commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816640402


   @rhtyd @ggoodrich-ipp  How I can help to test this pr? Could you provide some test scenario?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-818038412


   > Thanks @ggoodrich-ipp good to know this is already tested in production, @DaanHoogland thanks let's review/test on #4904
   > @ggoodrich-ipp should we close this PR then, and can you help share your testing/feedback details on #4904
   
   I don't have strong feelings on which PR we choose, as long as we get this enhancement into the code base so that at some point in the future it is there. I will let you @rhtyd @DaanHoogland @weizhouapache and others make that determination. We are already managing this change in our own fork for our production environment. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643529914


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-689500247


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696599589


   <b>Trillian test result (tid-2819)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 78226 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t2819-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.23 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.50 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.51 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.29 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 16.76 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.30 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 74.19 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.19 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.61 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1513.54 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-768321175


   @ggoodrich-ipp 
   thanks for pr.
   could you fix the conflicts and make primate ui change ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-700531139


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2100


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-781672771


   > > @ggoodrich-ipp cool, thanks for update.
   > > I think you need to revert the change below in setup/db/create-schema.sql
   > > ```
   > >   `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
   > >   `split_connections` int(1) NOT NULL DEFAULT 0,
   > > ```
   > > 
   > > 
   > > all travis test failed with error
   > > ```
   > > [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project cloud-developer: An exception occured while executing the Java class. null: InvocationTargetException: Unable to upgrade the database: Unable to execute upgrade script: Duplicate column name 'ike_version' -> [Help 1]
   > > ```
   > 
   > Shouldn't these SQL changes be in both places? I guess I'm confused. If you were doing a fresh installation, and not an upgrade, how would you get the columns?
   
   @ggoodrich-ipp 
   when setup a fresh installation, we need to setup database via cloudstack-setup-databases.
   ```
   Using specified cluster management server node IP 10.135.122.40                 [ ^[[92mOK^[[0m ]
   Checking Cloud database files ...                                               [ ^[[92mOK^[[0m ]
   Checking local machine hostname ...                                             [ ^[[92mOK^[[0m ]
   Checking SELinux setup ...                                                      [ ^[[92mOK^[[0m ]
   Preparing /etc/cloudstack/management/db.properties                              [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/create-database.sql             [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/create-schema.sql               [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/create-database-premium.sql     [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/create-schema-premium.sql       [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/server-setup.sql                [ ^[[92mOK^[[0m ]
   Applying /usr/share/cloudstack-management/setup/templates.sql                   [ ^[[92mOK^[[0m ]
   Processing encryption ...                                                       [ ^[[92mOK^[[0m ]
   Finalizing setup ...                                                            [ ^[[92mOK^[[0m ]
   ```
   it will create some tables.
   when restart mgt server, cloudstack will perform database upgrade.
   ```
   2021-02-16 14:58:47,736 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade40to41 to upgrade from 4.0.0-4.1.0 to 4.1.0
   2021-02-16 14:58:55,307 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade410to420 to upgrade from 4.1.0-4.2.0 to 4.2.0
   2021-02-16 14:59:05,234 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade420to421 to upgrade from 4.2.0-4.2.1 to 4.2.1
   2021-02-16 14:59:05,348 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade421to430 to upgrade from 4.2.1-4.3.0 to 4.3.0
   2021-02-16 14:59:10,576 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade430to440 to upgrade from 4.3.0-4.4.0 to 4.4.0
   2021-02-16 14:59:17,909 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade440to441 to upgrade from 4.4.0-4.4.1 to 4.4.1
   2021-02-16 14:59:18,179 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade441to442 to upgrade from 4.4.1-4.4.2 to 4.4.2
   2021-02-16 14:59:18,203 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade442to450 to upgrade from 4.4.2-4.5.0 to 4.5.0
   2021-02-16 14:59:24,759 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade443to444 to upgrade from 4.4.3-4.4.4 to 4.4.4
   2021-02-16 14:59:24,792 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade450to451 to upgrade from 4.5.0-4.5.1 to 4.5.1
   2021-02-16 14:59:24,917 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade451to452 to upgrade from 4.5.1-4.5.2 to 4.5.2
   2021-02-16 14:59:25,149 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade452to453 to upgrade from 4.5.2-4.5.3 to 4.5.3
   2021-02-16 14:59:25,173 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade453to460 to upgrade from 4.5.3-4.6.0 to 4.6.0
   2021-02-16 14:59:26,139 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade460to461 to upgrade from 4.6.0-4.6.1 to 4.6.1
   2021-02-16 14:59:26,180 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade461to470 to upgrade from 4.6.1-4.7.0 to 4.7.0
   2021-02-16 14:59:26,608 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade470to471 to upgrade from 4.7.0-4.7.1 to 4.7.1
   2021-02-16 14:59:26,716 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade471to480 to upgrade from 4.7.1-4.8.0 to 4.8.0
   2021-02-16 14:59:26,848 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade480to481 to upgrade from 4.8.0-4.8.1 to 4.8.1
   2021-02-16 14:59:26,884 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade481to490 to upgrade from 4.8.1-4.9.0 to 4.9.0
   2021-02-16 14:59:29,859 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade490to4910 to upgrade from 4.9.0-4.9.1.0 to 4.9.1.0
   2021-02-16 14:59:30,392 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade4910to4920 to upgrade from 4.9.1.0-4.9.2.0 to 4.9.2.0
   2021-02-16 14:59:30,681 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade4920to4930 to upgrade from 4.9.2.0-4.9.3.0 to 4.9.3.0
   2021-02-16 14:59:30,797 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade4930to41000 to upgrade from 4.9.3.0-4.10.0.0 to 4.10.0.0
   2021-02-16 14:59:32,061 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41000to41100 to upgrade from 4.10.0.0-4.11.0.0 to 4.11.0.0
   2021-02-16 14:59:33,903 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41100to41110 to upgrade from 4.11.0.0-4.11.1.0 to 4.11.1.0
   2021-02-16 14:59:34,096 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41110to41120 to upgrade from 4.11.1.0-4.11.2.0 to 4.11.2.0
   2021-02-16 14:59:34,320 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41120to41130 to upgrade from 4.11.2.0-4.11.3.0 to 4.11.3.0
   2021-02-16 14:59:34,348 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41120to41200 to upgrade from 4.11.2.0-4.12.0.0 to 4.12.0.0
   2021-02-16 14:59:35,463 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41200to41300 to upgrade from 4.12.0.0-4.13.0.0 to 4.13.0.0
   2021-02-16 14:59:36,613 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41300to41310 to upgrade from 4.13.0.0-4.13.1.0 to 4.13.1.0
   2021-02-16 14:59:36,635 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41310to41400 to upgrade from 4.13.1.0-4.14.0.0 to 4.14.0.0
   2021-02-16 14:59:37,499 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41400to41500 to upgrade from 4.14.0.0-4.15.0.0 to 4.15.0.0
   2021-02-16 14:59:39,493 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41500to41510 to upgrade from 4.15.0.0-4.15.1.0 to 4.15.1.0
   2021-02-16 14:59:39,529 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41510to41600 to upgrade from 4.15.1.0-4.16.0.0 to 4.16.0.0
   ```
   
   
   hope it is clear to you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769249447


   > @ggoodrich-ipp
   > thanks for pr.
   > could you fix the conflicts and make primate ui change ?
   
   Should this be re-targeted to either 4.15 or 4.16 @DaanHoogland @rhtyd, I know the conflicts won't be resolved in master, due to the recent UI deprecation/switch to primate. We will be working towards getting these elements into a PR for primate soon, but it may be easier to include that in a separate PR. Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788021342


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-653724914


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-682453902


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1840


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-714368059


   @rhtyd @wido @weizhouapache do we merge this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784045912


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2808


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816655461


   @dhansenippathways can you help test #4595 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673937008


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-695811138


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-700498040


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642392650


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769858118


   > @ggoodrich-ipp all the ui conflicts are to files that should now moved to ui/legacy. However I connot see them on github. (cc @rhtyd ?)
   
   I believe they've been removed permanently in the 4.16/master branch now. Maybe I need to redo this PR, and rip out the old UI parts, and instead rewrite for the new UI?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-671235144


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-670623028


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673422697


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642387957


   Packaging result: ✔centos7 ✔debian. JID-1335


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-724933097


   so do we move this to 4.16, @rhtyd ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643529787


   @blueorangutan test
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059824


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-665084642






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816621133


   @ggoodrich-ipp can you fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-685507415


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] dhansenippathways commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
dhansenippathways commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-785990233


   Let me know if there's anything else I need to do on this pull request (i'm helping out @ggoodrich-ipp with this).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788743435


   > not sure about the static rules failure but the life cycle failures are due to centos7 limitation which are addressed in #4727 amongst many other things, This can be easily ported to a separate PR if we need to; [8eec8c6](https://github.com/apache/cloudstack/commit/8eec8c6cf6a6784ee7bc24a50114414d33b8b698)
   
   @DaanHoogland 
   but it worked before. might it be caused by a recent commit ? need to solve it asap.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816766158


   > @dhansenippathways can you help test #4595
   
   We tested this, and have been running these changes in our Production environment for around one year (4.11.3). We recently added the new UI elements to satisfy the requirements of the current versions.
   
   I'm hesitant to resolve the conflicts, as they're in a file that will continue to receive conflicts if the PR is not merged in a timely manner. I will certainly resolve them once it is determine which branch this PR will get pulled into. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-682423142


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-687650109


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-641712287


   @ggoodrich-ipp please check and fix python/lint issues, see travis failure: https://travis-ci.org/github/apache/cloudstack/jobs/696639652
   
   As PR has UI changes, please make submit a PR to the Primate repo [1] as per our agreement and vote to stop changes in the legacy UI [2] towards the next major release (4.15).
   
   [1] https://github.com/apache/cloudstack-primate
   [2] http://markmail.org/message/tblrbrtew6cvrusr


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-689870235


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-671235590


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696034459


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-684790758


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1872


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642380967


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-672211519


   <b>Trillian test result (tid-2350)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53524 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t2350-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 80 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_delete_kubernetes_supported_version | `Error` | 1807.91 | test_kubernetes_supported_versions.py
   test_02_vpc_privategw_static_routes | `Failure` | 318.60 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 323.60 | test_privategw_acl.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 481.23 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3904.61 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-695814937


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2051


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713353358


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769668458


   > > @ggoodrich-ipp
   > > thanks for pr.
   > > could you fix the conflicts and make primate ui change ?
   > 
   > Should this be re-targeted to either 4.15 or 4.16 @DaanHoogland @rhtyd, I know the conflicts won't be resolved in master, due to the recent UI deprecation/switch to primate. We will be working towards getting these elements into a PR for primate soon, but it may be easier to include that in a separate PR. Thoughts?
   
   @ggoodrich-ipp 4.15.0.0 has been released, 4.15 branch will only accept bug fixes and security fixes afaik. this should be targeted to master/4.16 I think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673937008


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788706978


   not sure about the static rules failure but the life cycle failures are due to centos7 limitation which are addressed in #4727 amongst many other things, This can be easily ported to a separate PR if we need to; https://github.com/apache/cloudstack/pull/4727/commits/8eec8c6cf6a6784ee7bc24a50114414d33b8b698


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-665083905


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696034244


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696599589


   <b>Trillian test result (tid-2819)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 78226 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t2819-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.23 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.50 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.51 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.29 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 16.76 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.30 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 74.19 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.19 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.61 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1513.54 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-698769177


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-781497001


   @DaanHoogland @rhtyd We've added the new UI elements, and removed the old UI elements. I believe we've resolved all conflicts and requests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-698769177


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-712822793


   Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2219


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#discussion_r569763820



##########
File path: setup/db/create-schema.sql
##########
@@ -2280,6 +2280,8 @@ CREATE TABLE `cloud`.`s2s_customer_gateway` (
   `domain_id` bigint unsigned NOT NULL,
   `account_id` bigint unsigned NOT NULL,
   `removed` datetime COMMENT 'date removed if not null',
+  `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
+  `split_connections` int(1) NOT NULL DEFAULT 0,

Review comment:
       @ggoodrich-ipp 
   this affects only fresh installation.
   
   need to add sqls in engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
   ```
   alter table s2s_customer_gateway add column `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2';
   alter table s2s_customer_gateway add column `split_connections` int(1) NOT NULL DEFAULT 0;
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642380623


   @ggoodrich-ipp np, that's why we've Travis. Yes, please send PR for Primate. 
   
   @blueorangutan package 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-697890545


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816633424


   @weizhouapache @GabrielBrascher @wido @kiwiflyer @ravening @soreana @svenvogel @DaanHoogland @andrijapanicsb @shwstppr @Pearl1594 @Spaceman1984 - this is an enhancement that may benefit other users - should we be considering for 4.15.1 iff it can be reviewed and tested?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047908


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-653732097


   Packaging result: ✔centos7 ✔debian. JID-1526


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784016886


   don't worry @dhansenippathways , these sometimes happen because we are to heavy for travis. I restarted those and we test in other ways as well.
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#discussion_r569763820



##########
File path: setup/db/create-schema.sql
##########
@@ -2280,6 +2280,8 @@ CREATE TABLE `cloud`.`s2s_customer_gateway` (
   `domain_id` bigint unsigned NOT NULL,
   `account_id` bigint unsigned NOT NULL,
   `removed` datetime COMMENT 'date removed if not null',
+  `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
+  `split_connections` int(1) NOT NULL DEFAULT 0,

Review comment:
       @ggoodrich-ipp 
   this affects only fresh installation.
   
   need to add sqls in engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
   ```
   ALTER TABLE `cloud`.`s2s_customer_gateway` ADD COLUMN `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2';
   ALTER TABLE `cloud`.`s2s_customer_gateway` ADD COLUMN `split_connections` int(1) NOT NULL DEFAULT 0;
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642392359


   @blueorangutan test 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696599589


   <b>Trillian test result (tid-2819)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 78226 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t2819-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.23 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.50 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.48 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.51 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.29 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 16.76 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.30 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 74.19 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.19 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.61 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1513.54 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059824


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on a change in pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on a change in pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#discussion_r578595276



##########
File path: setup/db/create-schema.sql
##########
@@ -2280,6 +2280,8 @@ CREATE TABLE `cloud`.`s2s_customer_gateway` (
   `domain_id` bigint unsigned NOT NULL,
   `account_id` bigint unsigned NOT NULL,
   `removed` datetime COMMENT 'date removed if not null',
+  `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
+  `split_connections` int(1) NOT NULL DEFAULT 0,

Review comment:
       Thanks @weizhouapache, we hadn't caught that. Those changes are now included.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-670636521


   Packaging result: ✔centos7 ✔debian. JID-1676


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-818032549


   Thanks @ggoodrich-ipp good to know this is already tested in production, @DaanHoogland thanks let's review/test on https://github.com/apache/cloudstack/pull/4904
   @ggoodrich-ipp should we close this PR then, and can you help share your testing/feedback details on https://github.com/apache/cloudstack/pull/4904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816761164


   This needs some serious testing by someone who has been playing and/or suffering with VPNs. Let's make sure we don't break anything. I like the PR in general.
   
   4.16 would be a better candidate, time-wise


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816654906


   @rhtyd @soreana @ggoodrich-ipp, I backported to 4.15 branch in #4904
   
   please have a look and a spin. cc @borisstoyanov @weizhouapache 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-697889908


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-698768823


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713353776


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788520987


   <b>Trillian test result (tid-3629)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37890 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t3629-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 860.26 | test_privategw_acl.py
   test_01_migrate_VM_and_root_volume | `Error` | 67.16 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 49.04 | test_vm_life_cycle.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788748027


   @weizhouapache Centos7 does not support live migration like ubuntu does due to the default installation of qemu. I think this default must have changesd recently but it was never stable. My fix would mean checking the host os and skipping the test if it is `Centos`. I would merge this with the live migration tests failing on centos. I'll start an ubuntu test.
   @blueorangutan test centos7 kvm-ubuntu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp edited a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp edited a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-816766158


   > @dhansenippathways can you help test #4595
   
   We tested this, and have been running these changes in our Production environment for around one year (4.11.3). We recently added the new UI elements to satisfy the requirements of the current versions.
   
   I'm hesitant to resolve the conflicts, as they're in a file that will continue to receive conflicts if the PR is not merged in a timely manner. I will certainly resolve them once it is determined which branch this PR will get pulled into. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#discussion_r569763820



##########
File path: setup/db/create-schema.sql
##########
@@ -2280,6 +2280,8 @@ CREATE TABLE `cloud`.`s2s_customer_gateway` (
   `domain_id` bigint unsigned NOT NULL,
   `account_id` bigint unsigned NOT NULL,
   `removed` datetime COMMENT 'date removed if not null',
+  `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
+  `split_connections` int(1) NOT NULL DEFAULT 0,

Review comment:
       @ggoodrich-ipp 
   this affects only fresh installation.
   
   need to add sqls in engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
   ```
   alter table cloud.s2s_customer_gateway add column `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2';
   alter table cloud.s2s_customer_gateway add column `split_connections` int(1) NOT NULL DEFAULT 0;
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-788021767


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673391371


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-700497210


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-684744255


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-689870789


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-712779277


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769668458


   > > @ggoodrich-ipp
   > > thanks for pr.
   > > could you fix the conflicts and make primate ui change ?
   > 
   > Should this be re-targeted to either 4.15 or 4.16 @DaanHoogland @rhtyd, I know the conflicts won't be resolved in master, due to the recent UI deprecation/switch to primate. We will be working towards getting these elements into a PR for primate soon, but it may be easier to include that in a separate PR. Thoughts?
   
   @ggoodrich-ipp 4.15.0.0 has been released, 4.15 branch will only accept bug fixes and security fixes afaik. this should be targeted to 4.16 I think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713745034


   <b>Trillian test result (tid-3032)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37073 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4137-t3032-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 84 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 391.26 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 457.95 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-686907528






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-781668752


   > @ggoodrich-ipp cool, thanks for update.
   > I think you need to revert the change below in setup/db/create-schema.sql
   > 
   > ```
   >   `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
   >   `split_connections` int(1) NOT NULL DEFAULT 0,
   > ```
   > 
   > all travis test failed with error
   > 
   > ```
   > [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project cloud-developer: An exception occured while executing the Java class. null: InvocationTargetException: Unable to upgrade the database: Unable to execute upgrade script: Duplicate column name 'ike_version' -> [Help 1]
   > ```
   
   Shouldn't these SQL changes be in both places? I guess I'm confused. If you were doing a fresh installation, and not an upgrade, how would you get the columns?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713102835


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2235


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642392650


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-695811138






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047908


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-786024650


   code lgtm


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-689531409


   Packaging result: ✔centos7 ✖centos8 ✖debian. JID-1934


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047226


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673391036


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673408292


   Packaging result: ✔centos7 ✔debian. JID-1733


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-642102847


   @rhtyd I've fixed the python lint issue. I apologize, I didn't realize there were linting rules on that. @svenvogel I made the change you requested to the German translation.
   I will be evaluating the changes necessary for primate. We pushed this PR largely due to the issue #3138, as we have been using this change in our environment for some time, so I dug up the commit from our local repo.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-712778564


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-653724843


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-684745675


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713051907


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-689500941


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-695810968


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059727


   @blueorangutan test
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-695810968


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-682422861


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-782159345


   > hope it is clear to you.
   @weizhouapache Yes, thanks for the explanation. I didn't realize that a new install was upgrading through all the versions. That makes sense now. Pushed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] dhansenippathways commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
dhansenippathways commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-783659064


   It looks like the build is failing on a timeout error.  Should we get the build re-kicked off or are there other errors that I'm missing?
   
   @DaanHoogland @ggoodrich-ipp 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-673423047


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-643059727






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-687655210


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1899


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-781665511


   @ggoodrich-ipp cool, thanks for update.
   I think you need to revert the change below in setup/db/create-schema.sql
   
   ```
     `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
     `split_connections` int(1) NOT NULL DEFAULT 0,
   ```
   
   all travis test failed with error
   ```
   [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project cloud-developer: An exception occured while executing the Java class. null: InvocationTargetException: Unable to upgrade the database: Unable to execute upgrade script: Duplicate column name 'ike_version' -> [Help 1]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-713051623


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784017377


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-781665511


   @ggoodrich-ipp cool, thanks for update.
   I think you need to revert the change below in setup/db/create-schema.sql
   
   ```
     `ike_version` varchar(5) NOT NULL DEFAULT 'ike' COMMENT 'one of ike, ikev1, ikev2',
     `split_connections` int(1) NOT NULL DEFAULT 0,
   ```
   
   all travis test failed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-670623467


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047226


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-687650233


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-832473007


   Moved to https://github.com/apache/cloudstack/pull/4953 and fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769760426


   @ggoodrich-ipp all the ui conflicts are to files that should now moved to ui/legacy. However I connot see them on github. (cc @rhtyd ?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-696034244


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org