You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:21:45 UTC
[GitHub] [hudi] KnightChess opened a new pull request, #6898: [HUDI-4954] Shade avro in all bundles where it is included
KnightChess opened a new pull request, #6898:
URL: https://github.com/apache/hudi/pull/6898
### Change Logs
#6829
fix classNotFound in diff engine when use avro
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6898:
URL: https://github.com/apache/hudi/pull/6898#discussion_r992212503
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -95,6 +95,7 @@
<include>org.apache.httpcomponents:fluent-hc</include>
<include>org.antlr:stringtemplate</include>
<include>org.apache.parquet:parquet-avro</include>
+ <include>org.apache.avro:avro</include>
Review Comment:
Can you also shade Avro in other remaining bundles?
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -294,6 +295,10 @@
<shadedPattern>org.apache.hudi.org.apache.hadoop.metrics2.util.MetricSampleQuantiles
</shadedPattern>
</relocation>
+ <relocation>
Review Comment:
If it is being shaded in spark bundle, then please ensure Avro is relocated in every other bundle, e.g. Hudi-hive-sync-bundle otherwise the two bundles (one with shaded Avro and another with unshaded Avro) will run into conflict.
@nsivabalan Do you see any issues with relocating Avro in hudi-hive-sync-bundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in all bundles where it is included
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272492967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61eaf020966ddc76821d9a068ad827b3e4d49fd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1277740606
@KnightChess we should resolve it holistically for all bundles. @codope has started https://github.com/apache/hudi/pull/6933 let's consolidate the efforts there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272890419
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
}, {
"hash" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12096",
"triggerID" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63b3358267571e4160faf5a074cc0160f0cdc587 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12096)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1275806694
after https://issues.apache.org/jira/browse/HUDI-4959 resolve, it will resolve ClassNotFound error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #6898:
URL: https://github.com/apache/hudi/pull/6898#discussion_r992259754
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -95,6 +95,7 @@
<include>org.apache.httpcomponents:fluent-hc</include>
<include>org.antlr:stringtemplate</include>
<include>org.apache.parquet:parquet-avro</include>
+ <include>org.apache.avro:avro</include>
Review Comment:
I have check engine bundle: hudi-flink-bundle, hudi-spark-bundle, hudi-presto-bundle, hudi-trino-bundle, hudi-hadoop-mr-bundle, for others moudle, I don't know if need shade it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272506012
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61eaf020966ddc76821d9a068ad827b3e4d49fd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086)
* 5544c4ee45e6aca18cd354a14a77127fa26500fa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272754478
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
}, {
"hash" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12096",
"triggerID" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5544c4ee45e6aca18cd354a14a77127fa26500fa Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088)
* 63b3358267571e4160faf5a074cc0160f0cdc587 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12096)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272506964
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61eaf020966ddc76821d9a068ad827b3e4d49fd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086)
* 5544c4ee45e6aca18cd354a14a77127fa26500fa Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272532659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5544c4ee45e6aca18cd354a14a77127fa26500fa Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess closed pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
KnightChess closed pull request #6898: [HUDI-4954] Shade avro in spark bundle
URL: https://github.com/apache/hudi/pull/6898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in all bundles where it is included
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272492098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61eaf020966ddc76821d9a068ad827b3e4d49fd8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in all bundles where it is included
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272491323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61eaf020966ddc76821d9a068ad827b3e4d49fd8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6898: [HUDI-4954] Shade avro in spark bundle
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6898:
URL: https://github.com/apache/hudi/pull/6898#issuecomment-1272752570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12086",
"triggerID" : "61eaf020966ddc76821d9a068ad827b3e4d49fd8",
"triggerType" : "PUSH"
}, {
"hash" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088",
"triggerID" : "5544c4ee45e6aca18cd354a14a77127fa26500fa",
"triggerType" : "PUSH"
}, {
"hash" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63b3358267571e4160faf5a074cc0160f0cdc587",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5544c4ee45e6aca18cd354a14a77127fa26500fa Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12088)
* 63b3358267571e4160faf5a074cc0160f0cdc587 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org