You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/13 09:00:29 UTC
[GitHub] [hadoop-ozone] flirmnave opened a new pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
flirmnave opened a new pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490
## What changes were proposed in this pull request?
Adding a log makes it easy to track the problem.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4269
## How was this patch tested?
Test on local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
Posted by GitBox <gi...@apache.org>.
cxorm commented on pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#issuecomment-709020567
Thanks @flirmnave for the work, +1.
And thanks @jojochuang for the report and review.
I have committed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] flirmnave commented on a change in pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
Posted by GitBox <gi...@apache.org>.
flirmnave commented on a change in pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#discussion_r503964885
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java
##########
@@ -212,6 +212,9 @@ public static boolean checkVolume(HddsVolume hddsVolume, String scmId, String
} else {
// The hdds root dir should always have 2 files. One is Version file
// and other is SCM directory.
+ logger.error("The hdds root dir {} should always have 2 files. " +
+ "One is Version file and other is SCM directory.",
Review comment:
Thanks @jojochuang for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] flirmnave commented on pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
Posted by GitBox <gi...@apache.org>.
flirmnave commented on pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#issuecomment-709086213
Thanks @cxorm for reviewing and committing it, and @jojochuang for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] jojochuang commented on a change in pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490#discussion_r503922135
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java
##########
@@ -212,6 +212,9 @@ public static boolean checkVolume(HddsVolume hddsVolume, String scmId, String
} else {
// The hdds root dir should always have 2 files. One is Version file
// and other is SCM directory.
+ logger.error("The hdds root dir {} should always have 2 files. " +
+ "One is Version file and other is SCM directory.",
Review comment:
Let's add a more actionable message: "Please remove any other extra files from the directory so that DataNode startup can proceed."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm merged pull request #1490: HDDS-4269. Ozone DataNode thinks a volume is failed if an unexpected file is in the HDDS root directory.
Posted by GitBox <gi...@apache.org>.
cxorm merged pull request #1490:
URL: https://github.com/apache/hadoop-ozone/pull/1490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org