You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/22 05:17:33 UTC
[GitHub] [zookeeper] ctubbsii opened a new pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
ctubbsii opened a new pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514
This fixes issues with the C client tests, causing them to hang if
certain nameservices are in use (such as SSS), which use UNIX domain
sockets for getting the `getlogin()` and `getpwuid_r()`
This change makes the mocking of sockets less aggressive, since the
tests do not need to mock `AF_UNIX` socket types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514#issuecomment-714234312
@ztzg @symat - I think this might be a good fix, at least in the short term, for the issue we discussed in Slack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514#issuecomment-714299154
OK, I'll
thanks for the reminder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514#issuecomment-714298955
@symat please cherry pick to branch-3.6 if you are going to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1514: ZOOKEEPER-3983: Avoid mocking unix domain sockets
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1514:
URL: https://github.com/apache/zookeeper/pull/1514#issuecomment-714306038
merged, thanks @ctubbsii for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org