[jira] [Updated] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls

["Joshua McKenzie (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua McKenzie updated CASSANDRA-8584:
---------------------------------------
    Attachment: 8584_v1.txt

v1 attached.  Warns if we fail trySkipCache - it will require some digging if we get ourselves into a situation like this since we only have the integer fd at time of error and can't print out what file it failed on, but better to know we have a failure during unit tests / runtime than just silently failing and believing our system call was working.

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>             Fix For: 2.1.3
>
>         Attachments: 8584_v1.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary calls, it's thread-safe and we could print out more helpful information if we failed to prompt the kernel to skip the page cache.  That system call should always succeed unless we have an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)