You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/09 14:14:55 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2008: Drop duplicate constructor in ServiceLock
milleruntime opened a new pull request #2008:
URL: https://github.com/apache/accumulo/pull/2008
* Remove constructor in ServiceLock and make all services use the
constructor that takes a ZooKeeper object
* Get the authenticatedSession ZK from ServerContext instead of passing
in conf and parsing properties everytime.
* Simplify method in ServiceLockIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2008: Drop duplicate constructor in ServiceLock
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2008:
URL: https://github.com/apache/accumulo/pull/2008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2008: Drop duplicate constructor in ServiceLock
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2008:
URL: https://github.com/apache/accumulo/pull/2008#issuecomment-816753285
Was the reasoning behind this change discussed elsewhere? The changes look good, just looking for more insight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2008: Drop duplicate constructor in ServiceLock
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2008:
URL: https://github.com/apache/accumulo/pull/2008#issuecomment-816842600
The unit-tests pass locally. For some reason GitHub keeps timing out our second QA check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2008: Drop duplicate constructor in ServiceLock
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2008:
URL: https://github.com/apache/accumulo/pull/2008#issuecomment-816771387
> Was the reasoning behind this change discussed elsewhere? The changes look good, just looking for more insight.
Nope. I was examining the code while trying to decipher another bug and noticed the two similar constructors. Only having one constructor makes the class easier to follow everywhere it's created (like using find usage in an IDE) and is less code. The other improvements were just bonuses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org