You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/27 08:28:45 UTC

[GitHub] [incubator-kyuubi] turboFei opened a new pull request #1301: Stop engine command

turboFei opened a new pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955197092


   > I think we can combine this grammar (`EXEC ...` ?) and zorder, adding a new .g4 and something else seems not friendly for maintain.
   sure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955197092


   > I think we can combine this grammar (`EXEC ...` ?) and zorder, adding a new .g4 and something else seems not friendly for maintain.
   
   sure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955175894


   > cc @ulysses-you since this PR renames lots of package name of classes.
   
   Some class is only accessible in package `org.apache.spark.sql`, so I rename the package for convenience.
   
   And I think the extension is only for spark-sql, so, it makes senses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei closed pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei closed pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b5fbc3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.15%`.
   > The diff coverage is `74.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.34%   -0.16%     
   - Complexity      110      156      +46     
   ============================================
     Files           178      189      +11     
     Lines          7215     7439     +224     
     Branches        880      907      +27     
   ============================================
   + Hits           5664     5828     +164     
   - Misses         1067     1102      +35     
   - Partials        484      509      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `20.00% <20.00%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `50.72% <50.72%> (ø)` | |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `84.61% <84.61%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `88.88% <88.88%> (ø)` | |
   | [...uubi/sql/command/KyuubiCommandsSqlAstBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3FsQXN0QnVpbGRlci5zY2FsYQ==) | `90.90% <90.90%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...2b5fbc3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-981651368


   if it is needed, will reopen it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei removed a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei removed a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955177443






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1301: Stop engine command

Posted by GitBox <gi...@apache.org>.

pan3793 commented on a change in pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#discussion_r737232685



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/command/KyuubiCommands.g4
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar KyuubiCommands;
+
+@members {
+   /**
+    * Verify whether current token is a valid decimal token (which contains dot).
+    * Returns true if the character that follows the token is not a digit or letter or underscore.
+    *
+    * For example:
+    * For char stream "2.3", "2." is not a valid decimal token, because it is followed by digit '3'.
+    * For char stream "2.3_", "2.3" is not a valid decimal token, because it is followed by '_'.
+    * For char stream "2.3W", "2.3" is not a valid decimal token, because it is followed by 'W'.
+    * For char stream "12.0D 34.E2+0.12 "  12.0D is a valid decimal token because it is followed
+    * by a space. 34.E2 is a valid decimal token because it is followed by symbol '+'
+    * which is not a digit or letter or underscore.
+    */
+   public boolean isValidDecimal() {
+     int nextChar = _input.LA(1);
+     if (nextChar >= 'A' && nextChar <= 'Z' || nextChar >= '0' && nextChar <= '9' ||
+       nextChar == '_') {
+       return false;
+     } else {
+       return true;
+     }
+   }
+ }
+
+singleStatement
+    : statement ';'* EOF
+    ;
+
+statement
+    : STOP_ENGINE                                                      #stopEngine
+    | .*?                                                              #passThrough
+    ;
+
+nonReserved
+    : STOP_ENGINE
+    ;
+
+STOP_ENGINE: 'STOP_ENGINE';

Review comment:
       I think `'STOP ENGINE'` is more consistent with SQL grammar




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955177443


   But it seems that it also rename class  `KyuubiSparkSQLExtension`.
   
   So, let me make it compatible with before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955180891


   > cc @ulysses-you since this PR renames lots of package name of classes.
   
   revert back and just add a util class for some classes that only can be accessed in package `org.apache.spark.sql`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head 2b5fbc3. Consider uploading reports for the commit 2b5fbc3 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...2b5fbc3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head 4833b17. Consider uploading reports for the commit 4833b17 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...4833b17](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1301: Stop engine command

Posted by GitBox <gi...@apache.org>.

pan3793 commented on a change in pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#discussion_r737240929



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/command/KyuubiCommands.g4
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar KyuubiCommands;
+
+@members {
+   /**
+    * Verify whether current token is a valid decimal token (which contains dot).
+    * Returns true if the character that follows the token is not a digit or letter or underscore.
+    *
+    * For example:
+    * For char stream "2.3", "2." is not a valid decimal token, because it is followed by digit '3'.
+    * For char stream "2.3_", "2.3" is not a valid decimal token, because it is followed by '_'.
+    * For char stream "2.3W", "2.3" is not a valid decimal token, because it is followed by 'W'.
+    * For char stream "12.0D 34.E2+0.12 "  12.0D is a valid decimal token because it is followed
+    * by a space. 34.E2 is a valid decimal token because it is followed by symbol '+'
+    * which is not a digit or letter or underscore.
+    */
+   public boolean isValidDecimal() {
+     int nextChar = _input.LA(1);
+     if (nextChar >= 'A' && nextChar <= 'Z' || nextChar >= '0' && nextChar <= '9' ||
+       nextChar == '_') {
+       return false;
+     } else {
+       return true;
+     }
+   }
+ }
+
+singleStatement
+    : statement ';'* EOF
+    ;
+
+statement
+    : STOP_ENGINE                                                      #stopEngine
+    | .*?                                                              #passThrough
+    ;
+
+nonReserved
+    : STOP_ENGINE
+    ;
+
+STOP_ENGINE: 'STOP_ENGINE';

Review comment:
       BTW, Iceberg adds a new syntax called [procedure](https://iceberg.apache.org/spark-procedures/), which has less effort when adding a new one, e.g. not required to modify the Antlr grammar definition file every time, but it's not straightforward for the user as your current command approach.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1301: Stop engine command

Posted by GitBox <gi...@apache.org>.

turboFei commented on a change in pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#discussion_r737233516



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/command/KyuubiCommands.g4
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar KyuubiCommands;
+
+@members {
+   /**
+    * Verify whether current token is a valid decimal token (which contains dot).
+    * Returns true if the character that follows the token is not a digit or letter or underscore.
+    *
+    * For example:
+    * For char stream "2.3", "2." is not a valid decimal token, because it is followed by digit '3'.
+    * For char stream "2.3_", "2.3" is not a valid decimal token, because it is followed by '_'.
+    * For char stream "2.3W", "2.3" is not a valid decimal token, because it is followed by 'W'.
+    * For char stream "12.0D 34.E2+0.12 "  12.0D is a valid decimal token because it is followed
+    * by a space. 34.E2 is a valid decimal token because it is followed by symbol '+'
+    * which is not a digit or letter or underscore.
+    */
+   public boolean isValidDecimal() {
+     int nextChar = _input.LA(1);
+     if (nextChar >= 'A' && nextChar <= 'Z' || nextChar >= '0' && nextChar <= '9' ||
+       nextChar == '_') {
+       return false;
+     } else {
+       return true;
+     }
+   }
+ }
+
+singleStatement
+    : statement ';'* EOF
+    ;
+
+statement
+    : STOP_ENGINE                                                      #stopEngine
+    | .*?                                                              #passThrough
+    ;
+
+nonReserved
+    : STOP_ENGINE
+    ;
+
+STOP_ENGINE: 'STOP_ENGINE';

Review comment:
       it is in progress,
   
   I tried to use `STOP ENGINE` but failed.
   
   So just make it runnable at first.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

pan3793 edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955174349


   cc @ulysses-you since this PR renames lots of package name of classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head eaa6af9. Consider uploading reports for the commit eaa6af9 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...eaa6af9](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

pan3793 commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955174349


   cc @ulysses-you since this PR rename lots of package name of classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

ulysses-you commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955196109


   I think we can combine this grammar (`EXEC ...` ?) and zorder, adding a new .g4 and something else seems not friendly for maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head adc9115. Consider uploading reports for the commit adc9115 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...adc9115](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9f59dd) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.19%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head f9f59dd differs from pull request most recent head adc9115. Consider uploading reports for the commit adc9115 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.30%   -0.20%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5811     +147     
   - Misses         1067     1101      +34     
   - Partials        484      509      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...adc9115](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1301: Stop engine command

Posted by GitBox <gi...@apache.org>.

wForget commented on a change in pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#discussion_r737242397



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/command/KyuubiCommands.g4
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar KyuubiCommands;
+
+@members {
+   /**
+    * Verify whether current token is a valid decimal token (which contains dot).
+    * Returns true if the character that follows the token is not a digit or letter or underscore.
+    *
+    * For example:
+    * For char stream "2.3", "2." is not a valid decimal token, because it is followed by digit '3'.
+    * For char stream "2.3_", "2.3" is not a valid decimal token, because it is followed by '_'.
+    * For char stream "2.3W", "2.3" is not a valid decimal token, because it is followed by 'W'.
+    * For char stream "12.0D 34.E2+0.12 "  12.0D is a valid decimal token because it is followed
+    * by a space. 34.E2 is a valid decimal token because it is followed by symbol '+'
+    * which is not a digit or letter or underscore.
+    */
+   public boolean isValidDecimal() {
+     int nextChar = _input.LA(1);
+     if (nextChar >= 'A' && nextChar <= 'Z' || nextChar >= '0' && nextChar <= '9' ||
+       nextChar == '_') {
+       return false;
+     } else {
+       return true;
+     }
+   }
+ }
+
+singleStatement
+    : statement ';'* EOF
+    ;
+
+statement
+    : STOP_ENGINE                                                      #stopEngine
+    | .*?                                                              #passThrough
+    ;
+
+nonReserved
+    : STOP_ENGINE
+    ;
+
+STOP_ENGINE: 'STOP_ENGINE';

Review comment:
       We can define it like`execute func ()`, so that we don’t need to change the G4 file when we implement other functions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1301: Stop engine command

Posted by GitBox <gi...@apache.org>.

pan3793 commented on a change in pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#discussion_r737240929



##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/command/KyuubiCommands.g4
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+grammar KyuubiCommands;
+
+@members {
+   /**
+    * Verify whether current token is a valid decimal token (which contains dot).
+    * Returns true if the character that follows the token is not a digit or letter or underscore.
+    *
+    * For example:
+    * For char stream "2.3", "2." is not a valid decimal token, because it is followed by digit '3'.
+    * For char stream "2.3_", "2.3" is not a valid decimal token, because it is followed by '_'.
+    * For char stream "2.3W", "2.3" is not a valid decimal token, because it is followed by 'W'.
+    * For char stream "12.0D 34.E2+0.12 "  12.0D is a valid decimal token because it is followed
+    * by a space. 34.E2 is a valid decimal token because it is followed by symbol '+'
+    * which is not a digit or letter or underscore.
+    */
+   public boolean isValidDecimal() {
+     int nextChar = _input.LA(1);
+     if (nextChar >= 'A' && nextChar <= 'Z' || nextChar >= '0' && nextChar <= '9' ||
+       nextChar == '_') {
+       return false;
+     } else {
+       return true;
+     }
+   }
+ }
+
+singleStatement
+    : statement ';'* EOF
+    ;
+
+statement
+    : STOP_ENGINE                                                      #stopEngine
+    | .*?                                                              #passThrough
+    ;
+
+nonReserved
+    : STOP_ENGINE
+    ;
+
+STOP_ENGINE: 'STOP_ENGINE';

Review comment:
       BTW, Iceberg add a new syntax called [procedure](https://iceberg.apache.org/spark-procedures/), which has less effort when adding a new one, e.g. not required to modify the Antlr grammar definition file every time, but it's not straightforward for user as your current command apprach.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4833b17) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `73.39%`.
   
   > :exclamation: Current head 4833b17 differs from pull request most recent head 2b5fbc3. Consider uploading reports for the commit 2b5fbc3 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.32%   -0.19%     
   - Complexity      110      156      +46     
   ============================================
     Files           178      189      +11     
     Lines          7215     7436     +221     
     Branches        880      907      +27     
   ============================================
   + Hits           5664     5824     +160     
   - Misses         1067     1102      +35     
   - Partials        484      510      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `20.00% <20.00%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `50.72% <50.72%> (ø)` | |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `80.00% <80.00%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `88.88% <88.88%> (ø)` | |
   | [...uubi/sql/command/KyuubiCommandsSqlAstBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3FsQXN0QnVpbGRlci5zY2FsYQ==) | `90.90% <90.90%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...2b5fbc3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head 353088e. Consider uploading reports for the commit 353088e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...353088e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1301: Support kyuubi procedures

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1301:
URL: https://github.com/apache/incubator-kyuubi/pull/1301#issuecomment-955185534


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1301](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eae5931) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c6710ae9632db66470a090f205485d9e24f373a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6710ae) will **decrease** coverage by `0.18%`.
   > The diff coverage is `72.47%`.
   
   > :exclamation: Current head eae5931 differs from pull request most recent head 7c55a87. Consider uploading reports for the commit 7c55a87 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1301      +/-   ##
   ============================================
   - Coverage     78.50%   78.31%   -0.19%     
   - Complexity      110      155      +45     
   ============================================
     Files           178      189      +11     
     Lines          7215     7421     +206     
     Branches        880      904      +24     
   ============================================
   + Hits           5664     5812     +148     
   - Misses         1067     1101      +34     
   - Partials        484      508      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/sql/command/statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL3N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ql/zorder/ZorderSparkSqlExtensionsParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyQmFzZS5zY2FsYQ==) | `69.44% <ø> (-3.48%)` | :arrow_down: |
   | [...cala/org/apache/spark/sql/KyuubiSparkSqlUtil.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsvc3FsL0t5dXViaVNwYXJrU3FsVXRpbC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/kyuubi/sql/command/ResolveKyuubiProcedures.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Jlc29sdmVLeXV1YmlQcm9jZWR1cmVzLnNjYWxh) | `49.27% <49.27%> (ø)` | |
   | [...che/kyuubi/sql/KyuubiSparkSQLCommonExtension.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTcGFya1NRTENvbW1vbkV4dGVuc2lvbi5zY2FsYQ==) | `84.61% <50.00%> (-6.30%)` | :arrow_down: |
   | [...mmand/KyuubiCommandsSparkSqlExtensionsParser.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzU3BhcmtTcWxFeHRlbnNpb25zUGFyc2VyLnNjYWxh) | `68.57% <68.57%> (ø)` | |
   | [.../main/scala/org/apache/kyuubi/sql/ParserBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9QYXJzZXJCYXNlLnNjYWxh) | `83.33% <83.33%> (ø)` | |
   | [...apache/kyuubi/sql/command/ProcedureParameter.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL1Byb2NlZHVyZVBhcmFtZXRlci5zY2FsYQ==) | `83.33% <83.33%> (ø)` | |
   | [...he/kyuubi/sql/command/KyuubiDefinedProcedure.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaURlZmluZWRQcm9jZWR1cmUuc2NhbGE=) | `87.50% <87.50%> (ø)` | |
   | [...org/apache/kyuubi/sql/command/KyuubiCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jb21tYW5kL0t5dXViaUNvbW1hbmRzLnNjYWxh) | `88.88% <88.88%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6710ae...7c55a87](https://codecov.io/gh/apache/incubator-kyuubi/pull/1301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org