You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/06/29 21:16:56 UTC

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20143


Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK will be used to set IMPALA_JAVA_HOME_OVERRIDE (if a directory)
or IMPALA_JDK_VERSION before running tests, so the Impala cluster is
started with that JDK.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13526/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 18:30:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#7).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Restart Kudu with original JAVA_HOME in frontend tests.

Also skips restarting Hive and Ranger in tests as they'll restart with a
different JDK than originally started with.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
M tests/authorization/test_ranger.py
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_catalog_hms_failures.py
6 files changed, 31 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/7
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh@35
PS6, Line 35: # Use a different JDK for testing. Picked up by impala-config and start-impala-cluster.
            : if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then
            :   export MINICLUSTER_JAVA_HOME="${JAVA_HOME}"
            :   export IMPALA_JAVA_HOME_OVERRIDE="${TEST_JAVA_HOME_OVERRIDE}"
            : elif [ ! -z "${TEST_JDK_VERSION:-}" ]; then
            :   
> I'm still getting errors when I run the whole test suite. They go away when
Fixed with the latest patch set.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 15:13:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG@10
PS2, Line 10: TEST_JDK
> Is TEST_JDK a JDK version number or is it a path to a Java home?
It is either. I was being cute, but I could make it two variables instead.


http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@77
PS2, Line 77:     assumeTrue("Skip if testing a different JDK, as restarting Kudu with JDK 17 fails",
This causes a test error, so I think I need to rework this to be a test/cleanup rather than leveraging BeforeClass/AfterClass.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 19:01:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13451/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 15:53:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@50
PS6, Line 50:     if (!StringUtils.isEmpty(System.getenv("TEST_JDK_VERSION")) ||
            :         !StringUtils.isEmpty(System.getenv("TEST_JAVA_HOME_OVERRIDE"))) {
            :       // Don't restart Kudu with a different Java version.
            :       return;
            :     }
I'm wonder if there is a way we can fix up the environment variables so Kudu restarts with system JDK. We already pass in a whole environment to the Kudu start command.

At the same place we use TEST_JDK_VERSION and TEST_JAVA_HOME_OVERRIDE to set IMPALA_JAVA_HOME_OVERRIDE/IMPALA_JDK_VERSION, we could stash the system JDK in an environment variable. Then, here we override Kudu's JAVA_HOME if TEST_JDK_VERSION/TEST_JAVA_HOME_OVERRIDE is set?



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 19:51:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#3).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Also skips tests that restart Kudu as they'll restart Kudu with a
different JDK than it originally started with.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(1 comment)

A more complicated approach is to maintain two sets of Java environment variables. One set is for running Impala /tests. The other set is for everything else (build, minicluster, etc). Both would get set in bin/impala-config.sh with independent knobs. The individual scripts would be responsible for setting JAVA_HOME/LD_LIBRARY_PATH appropriately. bin/run-jvm-binary.sh would use the test-specific JAVA_HOME (and set LD_LIBRARY_PATH accordingly). The surefire fe test invocation would have to respect it as well. Minicluster components would use the regular java path. To really be disciplined about it, setting JAVA_HOME=unusable in bin/impala-config.sh might force every script to explicitly set JAVA_HOME from one of the two sources.

This can be a separate JIRA. It would take some work to smoke out the JAVA_HOME locations.

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh@35
PS6, Line 35: # Use a different JDK for testing. Picked up by impala-config and start-impala-cluster.
            : if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then
            :   export IMPALA_JAVA_HOME_OVERRIDE="${TEST_JAVA_HOME_OVERRIDE}"
            : elif [ ! -z "${TEST_JDK_VERSION:-}" ]; then
            :   export IMPALA_JDK_VERSION="${TEST_JDK_VERSION}"
            : fi
The steps to test locally would be:
1. Build normally
2. Make sure the minicluster is started
3. Set IMPALA_JAVA_HOME_OVERRIDE or IMPALA_JDK_VERSION
4. Set TEST_JAVA_HOME_OVERRIDE or TEST_JDK_VERSION
5. source bin/impala-config.sh again.
6. Run tests normally (but don't rebuild)



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 20:26:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10:

Failure seems like a transient, but no prior records of it. Re-running.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 21:46:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#6).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Also skips restarting Hive, Kudu, and Ranger in tests as they'll restart
with a different JDK than originally started with.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
M tests/authorization/test_ranger.py
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_catalog_hms_failures.py
6 files changed, 25 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/6
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53
PS5, Line 53:       return;
> Maybe we can use Assume.assumeTrue() to skip it? E.g.
I tried that but it errored the test run. I think it works differently in @BeforeClass than @Test.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 03:14:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 8: Code-Review+1

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jul 2023 23:23:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53
PS5, Line 53:       return;
> Ack
Maybe we can use Assume.assumeTrue() to skip it? E.g.
https://github.com/apache/impala/blob/7ca11dfc7fc26646f2e7194be74ba9739ea842bf/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java#L812
https://github.com/apache/impala/blob/bb7ad61c6c381ac25cd3fa198944230799fb8be8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java#L826



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 02:45:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#4).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Also skips restarting Kudu in tests as they'll restart Kudu with a
different JDK than it originally started with.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13457/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 20:48:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9531/


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 21:38:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 9: Code-Review+1

Carrying +1. This passed a full core test run with JDK 17.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 03:04:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG@15
PS5, Line 15: different JDK than it originally started with.
> Yeah, that makes sense. I suspect those are failing and I hadn't triaged th
test_catalog_hms_failures are only run in exhaustive, so won't immediately be an issue. And test_hive_with_ranger_setup passes, so I think Hive is ok to restart with Java 17 right now. But I'm also ok excluding it.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 00:04:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Restart Kudu with original JAVA_HOME in frontend tests.

Also skips restarting Hive, Kudu, and Ranger in tests as they'll restart
with a different JDK than originally started with.

Testing:
1. built normally
2. ran "TEST_JDK_VERSION=17 run-all-tests.sh"
3. verified various logs contain "java.specification.version:17"

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Reviewed-on: http://gerrit.cloudera.org:8080/20143
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
M tests/authorization/test_ranger.py
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_catalog_hms_failures.py
M tests/custom_cluster/test_custom_hive_configs.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
M tests/custom_cluster/test_metastore_events_cleanup.py
10 files changed, 40 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13572/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Jul 2023 03:27:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG@10
PS2, Line 10: TEST_JDK
> It is either. I was being cute, but I could make it two variables instead.
Done


http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/2/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@77
PS2, Line 77: 
> This causes a test error, so I think I need to rework this to be a test/cle
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 20:25:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG@15
PS5, Line 15: with a different JDK than originally started with.
> test_catalog_hms_failures are only run in exhaustive, so won't immediately 
Done


http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53
PS5, Line 53:       return;
> They don't actually depend on it, they just re-run an existing test suite w
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 11 Jul 2023 18:07:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/20143/3/bin/run-all-tests.sh@317
PS3, Line 317:       start_impala_cluster
> Not entirely sure these will combine right. Still figuring out the syntax.
Switched to just skipping in the test.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 20:45:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13459/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 21:09:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@50
PS6, Line 50:     if (!StringUtils.isEmpty(System.getenv("TEST_JDK_VERSION")) ||
            :         !StringUtils.isEmpty(System.getenv("TEST_JAVA_HOME_OVERRIDE"))) {
            :       // Don't restart Kudu with a different Java version.
            :       return;
            :     }
> I'm wonder if there is a way we can fix up the environment variables so Kud
I can do something like that.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jul 2023 16:27:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/20143/6/bin/run-all-tests.sh@35
PS6, Line 35: # Use a different JDK for testing. Picked up by impala-config and start-impala-cluster.
            : if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then
            :   export MINICLUSTER_JAVA_HOME="${JAVA_HOME}"
            :   export IMPALA_JAVA_HOME_OVERRIDE="${TEST_JAVA_HOME_OVERRIDE}"
            : elif [ ! -z "${TEST_JDK_VERSION:-}" ]; then
            :   
> The steps to test locally would be:
I'm still getting errors when I run the whole test suite. They go away when I run just the failing tests. My best guess is something is still restarting Hive, but I haven't found it yet.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jul 2023 23:24:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13440/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 21:40:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/2//COMMIT_MSG@10
PS2, Line 10: TEST_JDK
Is TEST_JDK a JDK version number or is it a path to a Java home?

It looks like it's either?



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 18:04:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG@15
PS5, Line 15: different JDK than it originally started with.
> We have some custom-cluster tests that will restart Hive. Should we make su
Yeah, that makes sense. I suspect those are failing and I hadn't triaged them yet.


http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53
PS5, Line 53:       return;
> I'm confused how the tests pass if they depend on Kudu running with HMS int
They don't actually depend on it, they just re-run an existing test suite with HMS integration enabled. I had trouble figuring out how to cleanly skip the test without upgrading to junit 5.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Jul 2023 16:38:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#8).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Restart Kudu with original JAVA_HOME in frontend tests.

Also skips restarting Hive and Ranger in tests as they'll restart with a
different JDK than originally started with.

Testing:
1. built normally
2. ran "TEST_JDK_VERSION=17 run-all-tests.sh"
3. verified various logs contain "java.specification.version:17"

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
M tests/authorization/test_ranger.py
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_catalog_hms_failures.py
6 files changed, 31 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/8
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#9).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK_VERSION sets IMPALA_JDK_VERSION before running tests, so the
Impala cluster is started with that JDK. TEST_JAVA_HOME_OVERRIDE sets
IMPALA_JAVA_HOME_OVERRIDE if a non-OS version of Java is required.

Restart Kudu with original JAVA_HOME in frontend tests.

Also skips restarting Hive, Kudu, and Ranger in tests as they'll restart
with a different JDK than originally started with.

Testing:
1. built normally
2. ran "TEST_JDK_VERSION=17 run-all-tests.sh"
3. verified various logs contain "java.specification.version:17"

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
M tests/authorization/test_ranger.py
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_catalog_hms_failures.py
M tests/custom_cluster/test_custom_hive_configs.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
M tests/custom_cluster/test_metastore_events_cleanup.py
10 files changed, 40 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/9
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13539/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jul 2023 17:43:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 9: Code-Review+2

Carrying Joe's +1. Thanks for the detailed tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 08:53:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9531/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 17:28:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 17:28:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Jul 2023 02:10:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9533/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 21:47:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20143/5//COMMIT_MSG@15
PS5, Line 15: different JDK than it originally started with.
We have some custom-cluster tests that will restart Hive. Should we make sure the original JDK is used?

https://github.com/apache/impala/blob/d52edc5e425b50f0b59ec1f8cc10698eb8f4282e/tests/authorization/test_ranger.py#L1939
https://github.com/apache/impala/blob/d52edc5e425b50f0b59ec1f8cc10698eb8f4282e/tests/custom_cluster/test_catalog_hms_failures.py#L49


http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java:

http://gerrit.cloudera.org:8080/#/c/20143/5/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@53
PS5, Line 53:       return;
I'm confused how the tests pass if they depend on Kudu running with HMS integration. Should we skip the test?



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Jul 2023 00:14:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20143

to look at the new patch set (#2).

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................

IMPALA-11941: (Addendum) ease testing other JDKs

Makes it simpler to build with one JDK and run tests with another.
TEST_JDK will be used to set IMPALA_JAVA_HOME_OVERRIDE (if a directory)
or IMPALA_JDK_VERSION before running tests, so the Impala cluster is
started with that JDK.

Also skips tests that restart Kudu when TEST_JDK is set, as they'll
restart Kudu with a different JDK than it originally started with.

Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
---
M bin/run-all-tests.sh
M fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/20143/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11941: (Addendum) ease testing other JDKs

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )

Change subject: IMPALA-11941: (Addendum) ease testing other JDKs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20143/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/20143/3/bin/run-all-tests.sh@317
PS3, Line 317:         SKIP_FE_TESTS=',!org.apache.impala.customservice.KuduHMSIntegrationTest'
Not entirely sure these will combine right. Still figuring out the syntax.



-- 
To view, visit http://gerrit.cloudera.org:8080/20143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00
Gerrit-Change-Number: 20143
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 20:29:35 +0000
Gerrit-HasComments: Yes