Re: [PR] test: add go test cases for `txn-context-enabled` config [kvrocks]

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #2530:
URL: https://github.com/apache/kvrocks/pull/2530#discussion_r1749615102


##########
tests/gocase/util/configs.go:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package util
+
+import "fmt"
+
+type FieldType int
+
+const (
+	YesNo FieldType = iota
+)
+
+type ConfigOptions struct {
+	Name       string
+	Options    []string
+	ConfigType FieldType
+}
+
+type KvrocksServerConfigs map[string]string
+
+func verifyConfigOptions(configType FieldType, option string) error {
+	switch configType {
+	case YesNo:
+		if option == "yes" || option == "no" {
+			break
+		}
+		return fmt.Errorf("invalid option for yes/no config")
+	default:
+		return fmt.Errorf("unsupported config type")
+	}
+	return nil
+}
+
+// / GenerateConfigsMatrix generates all possible combinations of config options
+func GenerateConfigsMatrix(configOptions []ConfigOptions) ([]KvrocksServerConfigs, error) {

Review Comment:
   So this only return false when options is error?



##########
tests/gocase/util/configs.go:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package util
+
+import "fmt"
+
+type FieldType int
+
+const (
+	YesNo FieldType = iota
+)
+
+type ConfigOptions struct {
+	Name       string
+	Options    []string
+	ConfigType FieldType
+}
+
+type KvrocksServerConfigs map[string]string
+
+func verifyConfigOptions(configType FieldType, option string) error {
+	switch configType {
+	case YesNo:
+		if option == "yes" || option == "no" {
+			break
+		}
+		return fmt.Errorf("invalid option for yes/no config")
+	default:
+		return fmt.Errorf("unsupported config type")
+	}
+	return nil
+}
+
+// / GenerateConfigsMatrix generates all possible combinations of config options
+func GenerateConfigsMatrix(configOptions []ConfigOptions) ([]KvrocksServerConfigs, error) {
+	configsMatrix := make([]KvrocksServerConfigs, 0)
+
+	var helper func(configs []ConfigOptions, index int, currentConfig map[string]string) error
+
+	helper = func(configs []ConfigOptions, currentIndex int, currentConfig map[string]string) error {
+		if currentIndex == len(configOptions) {
+			configsMatrix = append(configsMatrix, currentConfig)
+			return nil
+		}
+
+		currentConfigBackup := make(KvrocksServerConfigs, len(currentConfig))
+		for k, v := range currentConfig {
+			currentConfigBackup[k] = v
+		}

Review Comment:
   Copying this might be heavy weight but lgtm since it's just testing...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org