You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/28 16:51:14 UTC
Review Request: Added a Multimap with a nicer interface (+ tests) and
cleaned up implementation of multihashmap.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10166/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/third_party/Makefile.am 6c7f4743f8e5968bba58757229a34a797f5679ee
third_party/libprocess/third_party/stout/Makefile.am e623cae9a802d842c57f914fc4313b781eb9b6e3
third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp a8feabd24dce017ee61f10d3f474ba0db19f2aef
third_party/libprocess/third_party/stout/include/stout/multimap.hpp PRE-CREATION
third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp b41aa281e6855953eb3c8b0c87857709c7e61d47
third_party/libprocess/third_party/stout/tests/multimap_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/10166/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added a Multimap with a nicer interface (+ tests) and
cleaned up implementation of multihashmap.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 28, 2013, 5:21 p.m., Ben Mahler wrote:
> > third_party/libprocess/third_party/stout/include/stout/multimap.hpp, line 15
> > <https://reviews.apache.org/r/10166/diff/1/?file=275783#file275783line15>
> >
> > So we have Multimap, and multihashmap, do we want to capitalize the latter as well?
Yes, I'll be going around and s/multihashmap/Multihashmap/ in another review.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10166/#review18465
-----------------------------------------------------------
On March 28, 2013, 3:51 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10166/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 3:51 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/Makefile.am 6c7f4743f8e5968bba58757229a34a797f5679ee
> third_party/libprocess/third_party/stout/Makefile.am e623cae9a802d842c57f914fc4313b781eb9b6e3
> third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp a8feabd24dce017ee61f10d3f474ba0db19f2aef
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp PRE-CREATION
> third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp b41aa281e6855953eb3c8b0c87857709c7e61d47
> third_party/libprocess/third_party/stout/tests/multimap_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10166/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added a Multimap with a nicer interface (+ tests) and
cleaned up implementation of multihashmap.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10166/#review18465
-----------------------------------------------------------
Ship it!
third_party/libprocess/third_party/stout/include/stout/multimap.hpp
<https://reviews.apache.org/r/10166/#comment38706>
So we have Multimap, and multihashmap, do we want to capitalize the latter as well?
third_party/libprocess/third_party/stout/include/stout/multimap.hpp
<https://reviews.apache.org/r/10166/#comment38707>
whitespace
- Ben Mahler
On March 28, 2013, 3:51 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10166/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 3:51 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/Makefile.am 6c7f4743f8e5968bba58757229a34a797f5679ee
> third_party/libprocess/third_party/stout/Makefile.am e623cae9a802d842c57f914fc4313b781eb9b6e3
> third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp a8feabd24dce017ee61f10d3f474ba0db19f2aef
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp PRE-CREATION
> third_party/libprocess/third_party/stout/tests/multihashmap_tests.cpp b41aa281e6855953eb3c8b0c87857709c7e61d47
> third_party/libprocess/third_party/stout/tests/multimap_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10166/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>