You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/23 16:08:02 UTC
[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2185
[MINOR][ZEPPELIN-2308] Fix vis icon button group
### What is this PR for?
Since "Save" button which shows up when there is change in the package bundle ordering is included in same button group with other Helium viz icon buttons, the rightmost viz icon is not regarded as last child. For this reason, its border radius is a bit wired.
<img src="https://cloud.githubusercontent.com/assets/10060731/24257346/f928756a-102d-11e7-8c06-c7d58ac2b331.png" width="200px">
So I separated "Save" button from the icon btn group.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2308](https://issues.apache.org/jira/browse/ZEPPELIN-2308)
### Screenshots (if appropriate)
- Before
<img width="166" alt="before" src="https://cloud.githubusercontent.com/assets/10060731/24257314/e03ca210-102d-11e7-9155-82684bf9edbc.png">
- After
<img width="165" alt="after" src="https://cloud.githubusercontent.com/assets/10060731/24257317/e24d4352-102d-11e7-88f6-63be3c509cd3.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2185
----
commit 7faf814ac1078b8ec9e6b7fae067a919eaefe27e
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-23T16:00:51Z
Fix vis icon button group
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button group
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2185
@Leemoonsoo Thanks!
Merge into master and branch-0.7 if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2185
[MINOR][ZEPPELIN-2308] Fix vis icon button group
### What is this PR for?
Since "Save" button which shows up when there is change in the package bundle ordering is included in same button group with other Helium viz icon buttons, the rightmost viz icon is not regarded as last child. For this reason, its border radius is a bit wired.
<img src="https://cloud.githubusercontent.com/assets/10060731/24257346/f928756a-102d-11e7-8c06-c7d58ac2b331.png" width="200px">
So I separated "Save" button from the icon btn group.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2308](https://issues.apache.org/jira/browse/ZEPPELIN-2308)
### Screenshots (if appropriate)
- Before
<img width="166" alt="before" src="https://cloud.githubusercontent.com/assets/10060731/24257314/e03ca210-102d-11e7-9155-82684bf9edbc.png">
- After
<img width="165" alt="after" src="https://cloud.githubusercontent.com/assets/10060731/24257317/e24d4352-102d-11e7-88f6-63be3c509cd3.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2185
----
commit 7faf814ac1078b8ec9e6b7fae067a919eaefe27e
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-23T16:00:51Z
Fix vis icon button group
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button grou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2185: [MINOR][ZEPPELIN-2308] Fix vis icon button group
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2185
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---