[GitHub] [airflow] potiuk commented on issue #20862: Unexpected keyword argument 'resolver' during `airflow db init`

[GitBox <gi...@apache.org>]

potiuk commented on issue #20862:
URL: https://github.com/apache/airflow/issues/20862#issuecomment-1013836466


   > > We should do that in our setup.py as well. Or, since the error came from the _vendor_ connexion, it may be possible to fix this in the Airflow code base. What’s our policy about modifying vendor code?
   > 
   > No formal policy AFAIK
   
   @kaxil is right we have no formal policy but I think the approach we used so far was that we do not modify vendored-in code unless we really need to do it and there is no other way. Basically the only modifications we want to have in the vendored-in code are those that are the reason on why we vendored in the code in the first place.
   
   I believe in this case it will be just easier to add it in setup.cfg - we might want to bump the connexion version anyway at some point (they are at 2.10.0 version and we vendored in 2.7.0 so the least number of changes we will have to re-apply, the better). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org