You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/25 11:07:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #7256: [AIRFLOW-6635]
Speed up stattic checks
potiuk opened a new pull request #7256: [AIRFLOW-6635] Speed up stattic checks
URL: https://github.com/apache/airflow/pull/7256
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7256: [AIRFLOW-6635] Speed up
static checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256#issuecomment-578398152
Note in the current run it will run slower - but I will re-run it if it succeds when master images will rebuild in Dockerhub. Last night python base images were released with latest security/bugfixes and until our master images rebuild in dockerhub (about 4-5 hours from now) all the builds will generally be slower as we rebuild all images from the scratch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7256: [AIRFLOW-6635] Speed up
static checks
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7256:
[AIRFLOW-6635] Speed up static checks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256#issuecomment-578400523
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=h1) Report
> Merging [#7256](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ce3635d64f2eba9616709fb9d998676aa34b0875?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7256 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 791 791
Lines 40137 40137
=======================================
Hits 34252 34252
Misses 5885 5885
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=footer). Last update [ce3635d...bb72f0a](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7256: [AIRFLOW-6635] Speed
up static checks
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256#issuecomment-578400523
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=h1) Report
> Merging [#7256](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ce3635d64f2eba9616709fb9d998676aa34b0875?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7256 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 791 791
Lines 40137 40137
=======================================
Hits 34252 34252
Misses 5885 5885
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=footer). Last update [ce3635d...bb72f0a](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7256: [AIRFLOW-6635] Speed up
static checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256#issuecomment-578415871
We are now to 9 mins elapsed time for static checks total if both jobs run in parallell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7256:
[AIRFLOW-6635] Speed up static checks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7256: [AIRFLOW-6635] Speed up static checks
URL: https://github.com/apache/airflow/pull/7256#issuecomment-578400523
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=h1) Report
> Merging [#7256](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ce3635d64f2eba9616709fb9d998676aa34b0875?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7256 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 791 791
Lines 40137 40137
=======================================
Hits 34252 34252
Misses 5885 5885
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=footer). Last update [ce3635d...bb72f0a](https://codecov.io/gh/apache/airflow/pull/7256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services