[GitHub] [guacamole-client] jsalatiel commented on pull request #407: GUACAMOLE-805: Handle OpenID "id_token" parameter regardless of location in URL fragment.

[GitBox <gi...@apache.org>]

jsalatiel commented on pull request #407:
URL: https://github.com/apache/guacamole-client/pull/407#issuecomment-638512460


   Sorry to bother in this issue, but I have compiled 1.1.0 patched with the commits from this issue, but I keep in a redirect loop. The only difference is that:
   
   In the unpatched version, i can see in my browser window:
   ![image](https://user-images.githubusercontent.com/5522389/83698389-b1eef280-a5d7-11ea-9286-dc2d6ef4ece8.png)
   and URL looping between 
   http://MYDOMAIN_HERE/guacamole/#/session_state=SESSION_ID&id_token=ID_HERE 
   and
   http://MYDOMAIN_HERE/guacamole/#session_state=SESSION_ID&id_token=ID_HERE
   
   and using the patched version there is a blank screen in the browser and a loop between 
   
   http://MYDOMAIN_HERE/guacamole/#/?session_state=SESSION_ID&id_token=ID_HERE 
   and 
   http://MYDOMAIN_HERE/guacamole/#session_state=SESSION_ID&id_token=ID_HERE 
   
   
   I am not asking for any releases, just commenting here so maybe someone can check and fix if there is still some problem with openid .
   
   I am using keycloak 10 as the OID provider.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org