You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/01/05 10:06:06 UTC

svn commit: r1872346 - in /pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff: Type1CharString.java Type2CharString.java

Author: tilman
Date: Sun Jan  5 10:06:06 2020
New Revision: 1872346

URL: http://svn.apache.org/viewvc?rev=1872346&view=rev
Log:
PDFBOX-4071: use isEmpty()

Modified:
    pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java
    pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java

Modified: pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java?rev=1872346&r1=1872345&r2=1872346&view=diff
==============================================================================
--- pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java (original)
+++ pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java Sun Jan  5 10:06:06 2020
@@ -182,7 +182,7 @@ public class Type1CharString
         }
         else if ("vmoveto".equals(name))
         {
-            if (numbers.size() >= 1)
+            if (!numbers.isEmpty())
             {
                 if (isFlex)
                 {
@@ -197,7 +197,7 @@ public class Type1CharString
         }
         else if ("hmoveto".equals(name))
         {
-            if (numbers.size() >= 1)
+            if (!numbers.isEmpty())
             {
                 if (isFlex)
                 {
@@ -219,14 +219,14 @@ public class Type1CharString
         }
         else if ("hlineto".equals(name))
         {
-            if (numbers.size() >= 1)
+            if (!numbers.isEmpty())
             {
                 rlineTo(numbers.get(0), 0);
             }
         }
         else if ("vlineto".equals(name))
         {
-            if (numbers.size() >= 1)
+            if (!numbers.isEmpty())
             {
                 rlineTo(0, numbers.get(0));
             }
@@ -293,7 +293,7 @@ public class Type1CharString
         }
         else if ("callothersubr".equals(name))
         {
-            if (numbers.size() >= 1)
+            if (!numbers.isEmpty())
             {
                 callothersubr(numbers.get(0).intValue());
             }

Modified: pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java?rev=1872346&r1=1872345&r2=1872346&view=diff
==============================================================================
--- pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java (original)
+++ pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java Sun Jan  5 10:06:06 2020
@@ -211,7 +211,7 @@ public class Type2CharString extends Typ
         else if ("hintmask".equals(name) || "cntrmask".equals(name))
         {
             numbers = clearStack(numbers, numbers.size() % 2 != 0);
-            if (numbers.size() > 0)
+            if (!numbers.isEmpty())
             {
                 expandStemHints(numbers, false);
             }
@@ -308,7 +308,7 @@ public class Type2CharString extends Typ
 
     private void drawAlternatingLine(List<Number> numbers, boolean horizontal)
     {
-        while (numbers.size() > 0)
+        while (!numbers.isEmpty())
         {
             addCommand(numbers.subList(0, 1), new CharStringCommand(
                     horizontal ? 6 : 7));