You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/01/15 01:07:57 UTC
[PR] GH-518: Cleanup apache-arrow-java.tar.gz created by pre-commit [arrow-java]
kou opened a new pull request, #519:
URL: https://github.com/apache/arrow-java/pull/519
Fixes GH-518.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-518: Cleanup apache-arrow-java.tar.gz created by pre-commit [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #519:
URL: https://github.com/apache/arrow-java/pull/519#discussion_r1915843100
##########
.pre-commit-config.yaml:
##########
@@ -35,7 +35,8 @@ repos:
git archive HEAD \
--prefix=apache-arrow-java/ \
--output=apache-arrow-java.tar.gz && \
- dev/release/run_rat.sh apache-arrow-java.tar.gz"
+ dev/release/run_rat.sh apache-arrow-java.tar.gz && \
+ rm -f apache-arrow-java.tar.gz"
Review Comment:
Yes. In the case, we should check `apache-arrow-java.tar.gz`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-518: Cleanup apache-arrow-java.tar.gz created by pre-commit [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #519:
URL: https://github.com/apache/arrow-java/pull/519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-518: Cleanup apache-arrow-java.tar.gz created by pre-commit [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #519:
URL: https://github.com/apache/arrow-java/pull/519#discussion_r1915834965
##########
.pre-commit-config.yaml:
##########
@@ -35,7 +35,8 @@ repos:
git archive HEAD \
--prefix=apache-arrow-java/ \
--output=apache-arrow-java.tar.gz && \
- dev/release/run_rat.sh apache-arrow-java.tar.gz"
+ dev/release/run_rat.sh apache-arrow-java.tar.gz && \
+ rm -f apache-arrow-java.tar.gz"
Review Comment:
I guess it will get left behind if run_rat fails, but I suppose that's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org