[GitHub] [daffodil] stevedlawrence commented on pull request #605: Replace logging infrastructure with Log4j

[GitBox <gi...@apache.org>]

stevedlawrence commented on pull request #605:
URL: https://github.com/apache/daffodil/pull/605#issuecomment-876702282


   > You should try turning on all logging levels (full logging, "trace" level?) and run our test suite. It should still work, excepting tests that themselves are turning on/off logging. I know with the old logging, turning it on frequently resulted in stack overflows, circular OOLAG, or just aborts. All such failures are bugs. They don't have to be fixed in this PR, but we should find them anyway, or make a separate task to fix so that one can always turn logging on.
   
   I did turn on trace level logging and there was only one bad log messsage that caused issues. I forget where it came from, but the change to fix it was here:
   
   https://github.com/apache/daffodil/pull/605/files#diff-54ec9da14e47187ffdeeb515a11f925da7a44fee744fb423547135277973972bR242
   
   I didn't have any other issues with stack overflows or circularities or anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org