You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2023/01/02 15:12:10 UTC

[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #13314: Fix task group cannot release when kill task

github-code-scanning[bot] commented on code in PR #13314:
URL: https://github.com/apache/dolphinscheduler/pull/13314#discussion_r1060086291


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/CommonTaskProcessor.java:
##########
@@ -146,11 +146,13 @@
     public boolean killTask() {
 
         try {
-            taskInstance = taskInstanceDao.findTaskInstanceById(taskInstance.getId());
+            logger.info("Begin to kill task: {}", taskInstance.getName());

Review Comment:
   ## Dereferenced variable may be null
   
   Variable [taskInstance](1) may be null at this access as suggested by [this](2) null guard.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2459)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org