You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by wangli1426 <gi...@git.apache.org> on 2015/08/26 08:15:13 UTC

[GitHub] storm pull request: [STORM-1007] Isolate the code for metric colle...

GitHub user wangli1426 opened a pull request:

    https://github.com/apache/storm/pull/698

    [STORM-1007] Isolate the code for metric collection and retrieval from DisruptorQueue

    I created an inner class QueueMetrics for DisruptorQueue. The QueueMetrics class handles metric collection logics and exposes metric retrieval methods.
    
    The benefits of such modification are twofold: 
    1. It improves the readability of the metric code.
    2. It facilitates to add more metrics, such as average throughput and element sojourn time.  (That is because the data  maintained for such "stateful" metrics can reside in QueueMetrics rather than in DisruptorQueue. )

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangli1426/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #698
    
----
commit 4337ebe6e2398073e9a238e88bd51ca7b76b3437
Author: wangli1426 <wa...@gmail.com>
Date:   2015-08-26T04:48:27Z

    Created QueueMetrics inner class in DistruptorQueue to improve the extendibility and the readability of the metrics code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1008] Isolate the code for metric colle...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/698


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1007] Isolate the code for metric colle...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/698#issuecomment-135579159
  
    Hi @wangli1426 
    Maybe STORM-1008 is more proper issue to this PR, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1008] Isolate the code for metric colle...

Posted by wangli1426 <gi...@git.apache.org>.

Github user wangli1426 commented on the pull request:

    https://github.com/apache/storm/pull/698#issuecomment-135603939
  
    Hi @HeartSaVioR,
    Thanks for the comment. I'm sorry that It should be STORM-1008. I made a mistake on the number. And I have corrected the title of this PR. Please consider merging it or give me some advances. I will appreciate it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1008] Isolate the code for metric colle...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/698#issuecomment-135889977
  
    Great. +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---