[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10350: chore: enable no-unused-vars and prefer-template eslint rules

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10350:
URL: https://github.com/apache/incubator-superset/pull/10350#discussion_r456165670



##########
File path: superset-frontend/package.json
##########
@@ -129,7 +129,6 @@
     "d3-scale": "^2.1.2",
     "dnd-core": "^2.6.0",
     "dom-to-image": "^2.6.0",
-    "dompurify": "^2.0.7",

Review comment:
       the place where i removed this was the last instance of it, so i've removed it from package.json

##########
File path: superset-frontend/src/components/TableSelector.jsx
##########
@@ -103,11 +103,11 @@ export default class TableSelector extends React.PureComponent {
     });
   }
 
-  onDatabaseChange(db, selectChangeMeta) {
-    return this.changeDataBase(db);
+  onDatabaseChange(db, force) {

Review comment:
       @ktmud this is the only instance where instead of deleting the unused variable, I tried to fix logic that seemed to be missing. Could you confirm if this is a correct change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org