[GitHub] [camel] oscerd commented on a diff in pull request #10697: CAMEL-19584 : add KinesisAsyncClient to the camel component

["oscerd (via GitHub)" <gi...@apache.org>]

oscerd commented on code in PR #10697:
URL: https://github.com/apache/camel/pull/10697#discussion_r1264965869


##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -67,6 +67,8 @@ public class Kinesis2Configuration implements Cloneable {
     private Integer proxyPort;
     @UriParam(defaultValue = "false", description = "If we want to trust all certificates in case of overriding the endpoint")
     private boolean trustAllCertificates;
+    @UriParam(defaultValue = "false", description = "If we want to a KinesisAsyncClient instance set it to true")

Review Comment:
   This is producer only, so it needs to be labelled



##########
components/camel-aws/camel-aws2-kinesis/pom.xml:
##########
@@ -33,6 +33,7 @@
     <description>A Camel Amazon Kinesis Web Service Component Version 2</description>
 
     <properties>
+        <amazon-kinesis-common-version>2.5.1</amazon-kinesis-common-version>

Review Comment:
   This should go in Parent POM



##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/client/KinesisClientFactory.java:
##########
@@ -44,4 +45,14 @@ public static KinesisInternalClient getKinesisClient(Kinesis2Configuration confi
             return new KinesisClientStandardImpl(configuration);
         }
     }
+
+    /**
+     * Return the standard aws Kinesis Async client.
+     *
+     * @param  configuration configuration
+     * @return               KinesisAsyncClient
+     */
+    public static KinesisAsyncInternalClient getKinesisAsyncClient(Kinesis2Configuration configuration) {

Review Comment:
   The default and profile credentials are missing. It should be the same as the Sync client, so you should provide the other two implementations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org