You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/04 18:31:44 UTC
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15361
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
[build] Fix Netty errors in verify_jars.pl
This patch updates verify_jars.pl for Netty 4.
When Netty was upgraded the package name changed causing
verify_jars.pl to reported bad shaded classes & files.
Change-Id: I335119057e0665f09134e526396c4c2080ec4285
---
M build-support/verify_jars.pl
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/15361/1
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl@31
PS1, Line 31: so|swp
> Netty includes some libraries in META_INF for native epoll and kqueue. Nett
Thanks. For some reason I though we use this for verification of JARs we build for mini-cluster as well, but it's not the case it seems.
I downloaded netty-all-4.1.44.Final.jar from https://mvnrepository.com/artifact/io.netty/netty-all/4.1.44.Final and I don't see any '.dylib' files in there, indeed. But I also don't see '.swp' files in there. Interesting. Anyways, if you have a JAR with '.swp' files and it's indeed a part of the archive, probably it's something useful.
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 19:20:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl@31
PS1, Line 31: so|swp
nit: I'm curious what are these for? If .so is for dynamic libraries, do we expect to add dylib as well for macOS counterpart?
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 18:58:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl@31
PS1, Line 31: so|swp
> Thanks. For some reason I though we use this for verification of JARs we b
Ah, it looks like the swp file was from Guava. Regardless we don't want to report it here given we do want to shade Guava.
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 19:57:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 2:
Yes definitely, along with other Java static analysis stuff.
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 23:58:03 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 1: Verified+1
(1 comment)
The debug test failure was some issue downloading pandas in the python tests.
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:
http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl@31
PS1, Line 31: so|swp
> nit: I'm curious what are these for? If .so is for dynamic libraries, do
Netty includes some libraries in META_INF for native epoll and kqueue. Netty handles all of the usage of these and we don't use them by default.
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 19:09:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
[build] Fix Netty errors in verify_jars.pl
This patch updates verify_jars.pl for Netty 4.
When Netty was upgraded the package name changed causing
verify_jars.pl to reported bad shaded classes & files.
Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Reviewed-on: http://gerrit.cloudera.org:8080/15361
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/verify_jars.pl
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix Netty errors in verify jars.pl
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl
......................................................................
Patch Set 2:
At some point we should make this break the build, right?
--
To view, visit http://gerrit.cloudera.org:8080/15361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285
Gerrit-Change-Number: 15361
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 23:41:57 +0000
Gerrit-HasComments: No