You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/05/05 19:33:14 UTC
[GitHub] [solr-site] dsmiley opened a new pull request #22: Add Salesforce logo
dsmiley opened a new pull request #22:
URL: https://github.com/apache/solr-site/pull/22
I'm adding the Salesforce logo to list of Solr's prominent Solr deployments. I have internal approval for this, but there are some concerns on the spacing being too close to adjacent logos. Some logo images have internal margins, and some don't, which is inconsistent. Ironically, the eHarmony one I moved further away does have a margin and the Duck Duck Go one (now adjacent to Salesforce) does not, yet the vertical spot at which the text is next to the logos is different and creates a perceptive difference as to wether logos are too close or not. Ideally, I think the images would not have internal margins and we'd use some CSS attributes to control this so that we could be consistent. I haven't touched HTML & CSS in a _very_ long time so I could use some input from others on how to approach this.
I removed the "Other Notable Users" heading because, to me, it felt unnecessary based on the larger context and I didn't like that it had the same font face as the listing of companies below.
I saw a "Citeseer" comment next to Bloomberg. Citeseer is still a Solr user according to Wikipedia. On the other hand, I got confirmation from the Echo Nest that they are no longer Solr users, and so I think we should put Citeseer in there. A refresh of these users generally would be good in another PR. I can remove the Citeseer removal from this PR even though it was merely a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] dsmiley commented on pull request #22: Add Salesforce logo
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #22:
URL: https://github.com/apache/solr-site/pull/22#issuecomment-840265295
<img width="1085" alt="image" src="https://user-images.githubusercontent.com/377295/118073133-3c5bdc80-b379-11eb-888a-c8c5a74b88ed.png">
I put the extra padding on the div in an inline style on the element itself. Since it's very specific to the image it wraps, this seems better to me than putting this in a stylesheet where it's apart from the tag it's affecting. But I could understand a purest that might prefer never.
If I don't get further feedback, I'll merge this in a couple days or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] dsmiley merged pull request #22: Add Salesforce logo
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #22:
URL: https://github.com/apache/solr-site/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-site] dsmiley commented on pull request #22: Add Salesforce logo
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #22:
URL: https://github.com/apache/solr-site/pull/22#issuecomment-840555448
Come to think of it, let's be consistent and pad them all equally:
<img width="974" alt="image" src="https://user-images.githubusercontent.com/377295/118131114-190e4d00-b3cc-11eb-825b-576b273b8084.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org