You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 22:12:17 UTC
[GitHub] [arrow] Johnnathanalmeida opened a new pull request, #12804: [Gandiva][C++] Split Add_mappings() function in new files
Johnnathanalmeida opened a new pull request, #12804:
URL: https://github.com/apache/arrow/pull/12804
AddMappings function was with more than 1000 lines.
We split this function in new files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1091586300
Revision: f4f55b1edc20aadafa0458acda58a11ce6cadf1a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1826](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1826)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1826-github-java-jars)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1090755256
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12804: [Gandiva][C++] Split Add_mappings() function in new files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1089429619
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Johnnathanalmeida commented on pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
Johnnathanalmeida commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1091583467
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1090755201
https://issues.apache.org/jira/browse/ARROW-16136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12804:
URL: https://github.com/apache/arrow/pull/12804#issuecomment-1105936878
Benchmark runs are scheduled for baseline = f3047a605c7c3b874bbf9530efd728c16242bea8 and contender = f2d12138f410d37c343109a59a35619b821ea870. f2d12138f410d37c343109a59a35619b821ea870 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e013f673b85d4420925339ea9879bb1c...85fe868743ec4fc9bf4c7082c5be248d/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/585963a72fa14aec92525dab3b6ba39e...6fa9076d38f54f77ba117099e8b37a32/)
[Failed :arrow_down:0.38% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4355c68290e5499dbde1c6b5428fbe22...0cd11c1aeb2e4b26a9308f885925595a/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5c2d4ae3f18a4f99be2b40a82653ca8b...3bdbfb5519334e51bafbca05738db188/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/554| `f2d12138` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/542| `f2d12138` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/540| `f2d12138` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/552| `f2d12138` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/553| `f3047a60` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/541| `f3047a60` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/539| `f3047a60` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/551| `f3047a60` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pravindra closed pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
Posted by GitBox <gi...@apache.org>.
pravindra closed pull request #12804: ARROW-16136: [Gandiva][C++] Fix problem of the huge size of AddMappings function
URL: https://github.com/apache/arrow/pull/12804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org