You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/05 09:52:00 UTC

[jira] [Commented] (AVRO-2359) Support Logical Types in C#

    [ https://issues.apache.org/jira/browse/AVRO-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030501#comment-17030501 ] 

ASF subversion and git services commented on AVRO-2359:
-------------------------------------------------------

Commit 75e8f58c95e2b8c69af1a6f60c35a848a6781f0c in avro's branch refs/heads/master from Tim Roberts
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=75e8f58 ]

AVRO-2359: Support Logical Types in C# (#492)

* AVRO-2359: Support Logical Types in CSharp

* fix more warnings

* remove timezone change in TestTimestamp tests

* update logical Date and Time tests to be local time zone aware

* ensure TimeZone is set relative to a source TimeZone

* reparse Dates assuming local if they're not UTC

* try setting specific TimeZone offset

* actions for code review comments

* seperate the Timestamp* tests

* add missing license to AvroDecimalTests

* modify LogicalType to return .NET type rather than string

* add Register method to LogicalTypeFactory

* Fixup code-review comments

* Make Sign internal and add xmldocs

Co-authored-by: Fokko Driesprong <fo...@driesprong.frl>


> Support Logical Types in C#
> ---------------------------
>
>                 Key: AVRO-2359
>                 URL: https://issues.apache.org/jira/browse/AVRO-2359
>             Project: Apache Avro
>          Issue Type: New Feature
>          Components: csharp
>    Affects Versions: 1.8.2
>            Reporter: Tim Roberts
>            Priority: Critical
>
> By not supporting Logical Types, the C# Avro implementation is severely limited in terms of its interoperability in heterogeneous environments. While the implementation will safely ignore logical type declarations in processed schemas; at runtime the semantics of a "date" for example, will be lost when receiving an Avro payload that was encoded by the Java platform using the same schema. The C# implementation will never be able to retrieve the date value from the encoded int.
> I propose that the C# Avro implementation be extended to support the Logical Types as defined by the current specification. I have also explored the lang/csharp codebase and believe that I could produce a PR to support this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)