You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/15 08:19:34 UTC
[GitHub] williaster opened a new pull request #5208: [dashboard v2] ui + ux
fixes
williaster opened a new pull request #5208: [dashboard v2] ui + ux fixes
URL: https://github.com/apache/incubator-superset/pull/5208
This PR fixes a lot of UI/UX issues for the [new dashboard](https://github.com/apache/incubator-superset/pull/4528) for release.
- iterates on row/column visual hierarchy:
- rows and columns are always shown with dashed grey outlines
- on row/column hover, drop shadows are replaced with dashed blue outlines
- adds dashed blue outlines to header + chart + markdown components
<img src="https://user-images.githubusercontent.com/4496521/41455708-ebed88fc-7032-11e8-94dd-59411600d85b.gif" width="700" />
- adds empty drop targets at the top + bottom of `<Tab />` + `<DashboardGrid />` components which increase the size of the drop mouse target zone so that you can more easily drop at the edges of these components (shown as red below)
- adds more compressed loading gif and updates **all** references to `loading.gif` throughout the app to `<Loading />` so there is one source of truth
- makes heading style dropdown options match styles + fix hover/selected styles
<img src="https://user-images.githubusercontent.com/4496521/41455323-8f95ea32-7031-11e8-8cf3-ceb38fdb99a3.gif" width="300" />
- removes padding from markdown components when focused/editing to maximize editing space
<img src="https://user-images.githubusercontent.com/4496521/41455377-d046a2e2-7031-11e8-917e-ff4d58706d26.gif" width="300" />
- adds a slight red drop shadow to the cached data indicator to make it pop more
<img src="https://user-images.githubusercontent.com/4496521/41455425-fb08f91c-7031-11e8-8073-96607819ab36.png" width="300" />
- adds a mostly-transparent background to dragging slices which enables seeing the drop indicator more clearly
<img width="300" alt="screen shot 2018-06-15 at 1 16 02 am" src="https://user-images.githubusercontent.com/4496521/41457833-c55e3ebe-7039-11e8-8b81-41262ec83654.png">
- fixes a bug where the `moveComponent` action didn't trigger a `hasUnsavedChanges=true` update
- corrects dashboard load logging to account for first mount
@graceguo-supercat @elibrumbaugh
a couple more things to finish
**TODO**
- [x] verify logging fix
- [ ] ctrl+z/+y key listeners
- [ ] update loader gif to grey
- [ ] make header sticky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org