You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2026/06/28 22:45:55 UTC

[PR] fix: clone parquet-testing into `parquet` in verify-release-candidate.sh [datafusion-python]

adriangb opened a new pull request, #1617:
URL: https://github.com/apache/datafusion-python/pull/1617

   # Which issue does this PR close?
   
   <!-- No separate issue filed; this is a trivial fix to release tooling. -->
   
   No separate issue. This is a one-line fix to the release verification script, found while manually running the release verification process for 54.0.0-rc2.
   
   # Rationale for this change
   
   `dev/release/verify-release-candidate.sh` clones the parquet-testing repository into a directory named `parquet-testing`:
   
   ```bash
   git clone https://github.com/apache/parquet-testing.git parquet-testing
   ```
   
   However, the git submodule path declared in `.gitmodules` is `parquet`:
   
   ```
   [submodule "parquet"]
   	path = parquet
   	url = https://github.com/apache/parquet-testing.git
   ```
   
   and the parquet-based tests resolve their data relative to `parquet/data/...`, for example:
   
   - `python/tests/test_io.py`: `read_parquet(path="parquet/data/alltypes_plain.parquet")`
   - `python/tests/test_store.py`: `file://{Path.cwd()}/parquet/data/alltypes_plain.parquet`
   - `python/tests/test_context.py`: `parquet/data/alltypes_plain.parquet`
   
   The arrow-testing clone on the line immediately above already correctly uses its submodule path (`testing`), so the parquet line is an inconsistency.
   
   This is currently **latent**: the script's `python3 -m pytest` invocation is commented out (`#TODO: we should really run tests here as well`), so the wrong directory is never exercised today. If/when the test run is enabled during release verification, the parquet-reading tests would fail with *"No files found ... Cannot infer schema from an empty location"*. Fixing the clone path is a prerequisite for enabling those tests.
   
   # What changes are included in this PR?
   
   - Clone parquet-testing into `parquet` (instead of `parquet-testing`) so it matches the `.gitmodules` submodule path and the paths the test suite expects.
   
   # Are there any user-facing changes?
   
   No. This only affects the release verification tooling.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01Pj5DVU7MaammM2nfHh1ZRG


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: clone parquet-testing into `parquet` in verify-release-candidate.sh [datafusion-python]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #1617:
URL: https://github.com/apache/datafusion-python/pull/1617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: clone parquet-testing into `parquet` in verify-release-candidate.sh [datafusion-python]

Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #1617:
URL: https://github.com/apache/datafusion-python/pull/1617#issuecomment-4833531904

   > Since this PR removes the 3.13t wheel
   
   Sorry if I'm missing something: how does this PR remove the 3.13t wheel?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: clone parquet-testing into `parquet` in verify-release-candidate.sh [datafusion-python]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #1617:
URL: https://github.com/apache/datafusion-python/pull/1617#issuecomment-4842406091

   > how does this PR remove the 3.13t wheel?
   
   This is strange, here's the diff I saw yesterday
   <img width="807" height="314" alt="image" src="https://github.com/user-attachments/assets/37c47e78-d753-41e2-9c49-447af90f56b6" />
   
   I must have made a mistake, downloading the branch yesterday.
   
   I reviewed again here in github and my approval stands.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org