You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gdahia (via GitHub)" <gi...@apache.org> on 2023/09/08 16:19:30 UTC
[GitHub] [spark] gdahia opened a new pull request, #42858: Change "filter" to "transform" in transform function docstring
gdahia opened a new pull request, #42858:
URL: https://github.com/apache/spark/pull/42858
### What changes were proposed in this pull request?
This PR proposes a simple change in the documentation for the `transform` function in `sql`. I believe where it currently reads "filter" it should read "transform".
### Why are the changes needed?
I believe this change might not be needed per se, but it would be a slight improvement to the current version to avoid the misnomer.
### Does this PR introduce _any_ user-facing change?
Yes, it shows the word "transform' instead of "filter" in the documentation for the `transform` `sql`. function.
### How was this patch tested?
This patch was not tested because it only changes documentation.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in transform function docstring
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42858:
URL: https://github.com/apache/spark/pull/42858#issuecomment-1711948254
Yes, I can merge your contribution if this is the last typo in this file.
> I could, absolutely. Do you have some in mind, or those similar to transform and filter would already be a nice contribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in transform function docstring
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42858:
URL: https://github.com/apache/spark/pull/42858#issuecomment-1711985188
> I have reviewed the docstring in every function under the "Collection functions" section, and they all look ok to me :)
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in `transform` function docstring
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42858:
URL: https://github.com/apache/spark/pull/42858#issuecomment-1711987522
Merged to master branch for Apache Spark 4.0.0.
Congratulation for your first commit with author gdahia@protonmail.com and Welcome to the Apache Spark community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gdahia commented on pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in transform function docstring
Posted by "gdahia (via GitHub)" <gi...@apache.org>.
gdahia commented on PR #42858:
URL: https://github.com/apache/spark/pull/42858#issuecomment-1711983116
I have reviewed the docstring in every function under the "Collection functions" section, and they all look ok to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in `transform` function docstring
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in `transform` function docstring
URL: https://github.com/apache/spark/pull/42858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gdahia commented on pull request #42858: [MINOR][DOCS] Change "filter" to "transform" in transform function docstring
Posted by "gdahia (via GitHub)" <gi...@apache.org>.
gdahia commented on PR #42858:
URL: https://github.com/apache/spark/pull/42858#issuecomment-1711937292
> Thank you for making a PR. If you don't mind, could you check other functions in this file `sql/core/src/main/scala/org/apache/spark/sql/functions.scala`, please?
I could, absolutely. Do you have some in mind, or those similar to `transform` and `filter` would already be a nice contribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org