You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 22:53:27 UTC

[PR] [ISSUE-3842][test] Deepen MybatisPlusAlertCollectionLeaseTest with acquire paths and duplicate-key loss [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3842:
URL: https://github.com/apache/rocketmq-dashboard/pull/3842

   ### Motivation
   
   The existing `MybatisPlusAlertCollectionLeaseTest` covers `renew` outcomes only. The three `tryAcquire` paths — direct acquire success, insert fallback and duplicate-key lease loss — were untested.
   
   ### Changes
   
   - `tryAcquireSucceedsThroughTheMapperAcquirePath`: a successful conditional acquire returns true without any insert.
   - `tryAcquireFallsBackToInsertWhenAcquireMisses`: when the conditional acquire misses, an insert of the lease record grants the lease.
   - `tryAcquireTreatsDuplicateInsertAsLeaseLoss`: a duplicate-key insert failure is reported as lease loss rather than an error.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=MybatisPlusAlertCollectionLeaseTest
   [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE-3842][test] Deepen MybatisPlusAlertCollectionLeaseTest with acquire paths and duplicate-key loss [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3842: [ISSUE-3842][test] Deepen MybatisPlusAlertCollectionLeaseTest with acquire paths and duplicate-key loss
URL: https://github.com/apache/rocketmq-dashboard/pull/3842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org