You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/04 14:05:59 UTC

[GitHub] [flink-ml] lindong28 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

lindong28 commented on a change in pull request #10:
URL: https://github.com/apache/flink-ml/pull/10#discussion_r742867867



##########
File path: flink-ml-api/pom.xml
##########
@@ -38,6 +38,34 @@ under the License.
       <version>${flink.version}</version>
       <scope>provided</scope>
     </dependency>
+
+    <dependency>
+      <groupId>org.apache.flink</groupId>
+      <artifactId>flink-table-api-java-bridge_${scala.binary.version}</artifactId>

Review comment:
       Thanks for the review Zhipeng. You are right that `flink-table-api-java-bridge` and `flink-java` are not needed here. The `flink-table-planner` and `flink-test-utils` can be changed to use `test` scope since they are only needed by unit tests (e.g. PipelineTest).
   
   I will update the PR to fix this issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org