[jira] [Commented] (YETUS-138) Skipping maven poms that don't package causes testing holes

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977050#comment-14977050 ] 

Allen Wittenauer commented on YETUS-138:
----------------------------------------

The specific problem is this code:

{code}
  if [[ ${BUILDTOOL} = maven ]]; then
    # Filter out modules without code
    for module in ${builddirs}; do
      ${GREP} "<packaging>pom</packaging>" "${module}/pom.xml" > /dev/null
      if [[ "$?" != 0 ]]; then
        buildmods="${buildmods} ${module}"
      fi
    done
  else
    buildmods=${CHANGED_UNFILTERED_MODULES}
  fi
{code}

It's intent was to avoid doing a build in modules like hadoop-assemblies.  But honestly, I'm wondering if there is anything wrong with just running in them anyway.

> Skipping maven poms that don't package causes testing holes
> -----------------------------------------------------------
>
>                 Key: YETUS-138
>                 URL: https://issues.apache.org/jira/browse/YETUS-138
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>
> HADOOP-12114 impacts a pom that doesn't have a package.  As a result, it gets dropped from CHANGED_MODULES which triggers a cascade effect.  We need to have a better way to detect whether there is code to compile there or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)