You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/10/26 15:40:31 UTC

[GitHub] flink issue #2445: [FLINK-4544] Refactor old CPU metric initialization

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2445
  
    The approach looks good, but I think it would be good to adjust a few things:
      - We are migrating most of the Scala code in `flink-runtime` to Java (for example in FLIP-6), so would be good if this new code was also Java
      - Some of the Gauges use some form of JMX querying (`getAttribute(ObjectName)`) that looks more expensive then directly accessing a bean (calling a method)
      - Some metrics may not be available on all JVMs (like mapped direct memory). Can this make sure we don't log an exception on each access to the Gauge, when the JMX query fails?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---