You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/11 03:18:24 UTC
[PR] fix(dlq): ignore stale retry completions [rocketmq-dashboard]
123123213weqw opened a new pull request, #1563:
URL: https://github.com/apache/rocketmq-dashboard/pull/1563
## Summary
- assign each DLQ retry submission a request generation
- invalidate the active generation before changing instances and on unmount
- ignore stale success, error, refresh, dialog, and loading updates
- snapshot the submitted group and target for accurate completion messages
- cover an old retry resolving after a new instance retry dialog has opened
## Testing
- `NODE_OPTIONS=--no-experimental-webstorage npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx`
- `NODE_OPTIONS=--no-experimental-webstorage npx eslint src/pages/instance/dlq.tsx src/pages/instance/__tests__/DLQPage.test.tsx`
Fixes #1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dlq): ignore stale retry completions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1563:
URL: https://github.com/apache/rocketmq-dashboard/pull/1563#issuecomment-5253031026
Rework needed: trunk now resets DLQ state via the render-time scopeKey adjustment (merged via #1037 batch). Please rebase and keep the scopeKey approach while adding your retryRequestIdRef stale-response guard on top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dlq): ignore stale retry completions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1563:
URL: https://github.com/apache/rocketmq-dashboard/pull/1563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org