You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2016/07/30 08:47:28 UTC
wicket git commit: WICKET-6220 value of void element should be null
Repository: wicket
Updated Branches:
refs/heads/WICKET-6220-tag-tester-void-elements [created] b27e6aca9
WICKET-6220 value of void element should be null
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b27e6aca
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b27e6aca
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b27e6aca
Branch: refs/heads/WICKET-6220-tag-tester-void-elements
Commit: b27e6aca99519fa88bfea4f653a528cd41bc5c75
Parents: e79fcb8
Author: Sven Meier <sv...@apache.org>
Authored: Sat Jul 30 10:46:51 2016 +0200
Committer: Sven Meier <sv...@apache.org>
Committed: Sat Jul 30 10:46:51 2016 +0200
----------------------------------------------------------------------
.../src/main/java/org/apache/wicket/util/tester/TagTester.java | 4 ++++
.../test/java/org/apache/wicket/util/tester/TagTesterTest.java | 5 +++++
2 files changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/b27e6aca/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
index c6818f6..04f8280 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
@@ -359,6 +359,10 @@ public class TagTester
*/
public String getValue()
{
+ if (openTag == closeTag) {
+ return null;
+ }
+
int openPos = openTag.getPos() + openTag.getLength();
int closePos = closeTag.getPos();
http://git-wip-us.apache.org/repos/asf/wicket/blob/b27e6aca/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java b/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
index e7863a8..d184869 100644
--- a/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
@@ -20,6 +20,7 @@ import static org.hamcrest.Matchers.endsWith;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
+import static org.hamcrest.Matchers.nullValue;
import java.util.List;
@@ -51,6 +52,8 @@ public class TagTesterTest extends Assert
String type = tester.getAttribute("type");
assertThat(type, is(equalTo("text")));
+
+ assertThat(tester.getValue(), is(nullValue()));
}
/**
@@ -65,6 +68,8 @@ public class TagTesterTest extends Assert
String type = testers.get(0).getAttribute("type");
assertThat(type, is(equalTo("text")));
+
+ assertThat(testers.get(0).getValue(), is(nullValue()));
}
/**