You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by yelirekim <gi...@git.apache.org> on 2015/03/19 06:09:05 UTC
[GitHub] thrift pull request: THRIFT-3047: Fixing indentation for generated...
GitHub user yelirekim opened a pull request:
https://github.com/apache/thrift/pull/401
THRIFT-3047: Fixing indentation for generated cocoa sources
indent_down was called one extra time when generating the client which gave us an indentation level of -1, then to combat this, we indented the server implementation an extra level. This appeared as if everything was fine unless you generated more than one service in a thrift file, in which case the indentation would get progressively worse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yelirekim/thrift feature/cocoa-indentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #401
----
commit 6e02061253d3d0a1342fc9d67914bc991258b209
Author: Mike Riley <mi...@yelirekim.com>
Date: 2015-03-19T04:58:31Z
Fixing indentation for generated cocoa sources
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3047: Fixing indentation for generated...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/401
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---