You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vdiravka <gi...@git.apache.org> on 2017/10/31 11:56:00 UTC

[GitHub] drill pull request #1017: The query with "SELECT *" with "ORDER BY" clause a...

GitHub user vdiravka opened a pull request:

    https://github.com/apache/drill/pull/1017

    The query with "SELECT *" with "ORDER BY" clause and `planner.slice_t…

    …arget`=1 doesn't preserve column order
    
    Issue: Columns ordering doesn't preserve for the star query with sorting when this is planned into multiple fragments.
    Solution: The commit for DRILL-847 is oudated. There is no need to canonicalize the batch or container since RecordBatchLoader swallows the "schema change" for now if two batches have different column ordering.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vdiravka/drill DRILL-5822

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1017
    
----
commit 922505c35ed18f5cf76a5ded77a734827c15eb59
Author: Vitalii Diravka <vi...@gmail.com>
Date:   2017-10-26T18:07:33Z

    The query with "SELECT *" with "ORDER BY" clause and `planner.slice_target`=1 doesn't preserve column order
    
    - The commit for DRILL-847 is oudated. There is no need to canonicalize the batch or container since RecordBatchLoader
      swallows the "schema change" for now if two batches have different column ordering.

----


---

[GitHub] drill issue #1017: DRILL-5822: The query with "SELECT *" with "ORDER BY" cla...

Posted by vdiravka <gi...@git.apache.org>.

Github user vdiravka commented on the issue:

    https://github.com/apache/drill/pull/1017
  
    @paul-rogers Could you please review this PR? You can find a short description here or more detailed - in the jira ticket [DRILL-5822](https://issues.apache.org/jira/browse/DRILL-5822).


---

[GitHub] drill pull request #1017: DRILL-5822: The query with "SELECT *" with "ORDER ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1017


---