You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/04/03 14:31:00 UTC
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-docs/pull/201
CB-2606 Documented icon usage
1. iOS, Andoroid, FirefoxOS, Windows8, WP8
2. Related PR with support https://github.com/apache/cordova-cli/pull/126
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/cordova-docs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #201
----
commit cb0063f1475ee7af68b3ca0b87522bb895ea17a5
Author: Sergey Grebnov <v-...@microsoft.com>
Date: 2014-04-03T12:30:12Z
CB-2606 Documented icon usage
1. iOS, Andoroid, FirefoxOS, Windows8, WP8
2. Related PR with support https://github.com/apache/cordova-cli/pull/126
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/201#discussion_r11249330
--- Diff: docs/en/edge/config_ref/images.md ---
@@ -26,45 +26,76 @@ SDK tools (detailed in the Platform Guides).
## Configuring Icons in the CLI
-When working in the CLI, icon source files are located within various
-platform-specific subdirectories within the project's `www/res/icons`
-directory. Newly created projects come with a default set of Cordova
-icons for you to replace for the platforms you wish to target.
+When working in the CLI you can define app icon(s) via `<icon>` element (`config.xml`).
+If you do not specify an icon then the Apache Cordova logo is used.
-Android specifies icons for low, medium, high, and extra-high resolutions:
+ <icon src="res/ios/icon.png" platform="ios" width="57" height="57" density="mdpi" />
- android/icon-36-ldpi.png
- android/icon-48-mdpi.png
- android/icon-72-hdpi.png
- android/icon-96-xhdpi.png
+src: (required) specifies the location of the image file, relative to your www directory
-The iOS platform specifies 72-pixel-square icons for iPads, and
-57-pixel icons for iPhones and iPods, with high-resolution _2x_
-variants for retina displays:
+platform: (optional) target platform
- ios/icon-57-2x.png
- ios/icon-57.png
- ios/icon-72-2x.png
- ios/icon-72.png
+width: (optional) icon width in pixels
-Windows Phone specifies a default 48-pixel icon, along with various
-devices' background tiling images used when representing applications:
+height: (optional) icon height in pixels
- windows-phone/icon-48.png
- windows-phone/icon-62-tile.png
- windows-phone/icon-173-tile.png
+density: (optional) android specific, specifies icon density
-Blackberry 10 requires an icon element in config.xml:
--- End diff --
Temporary removed BB10 and Tizen related info since not sure it is actual. Will review and bring it back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-42548695
Looks like the code for these docs has already been merged in. Bryan / Sergey, is there anything remaining here before doing a merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-39448737
BB10 should be brought back in including the link to the best practices page. The platform config.xml supports icon element. CLI needs to be updated to filter out non-bb icon icon elements and copy over the default / bb10 specific files.
I would also recommend sorting the platforms alphabetically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-docs/pull/201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-docs pull request: CB-2606 Documented icon usage
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-42549099
This was already merged:
https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=commit;h=51a296ae367b01a480defba5bf818b2cff7cb790
https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=commit;h=41ae089996cfe00a9d17edf93ac2b4eb5b74b401
@sgrebnov could you please close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---