You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/31 22:25:24 UTC
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #43:
update dependencies
elharo opened a new pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43
@michael-o A couple more dependency updates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401534573
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
Yes, that's how I got the failure above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401396538
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
Does this incur any class hanges?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401546564
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
This likely applies to tests only because the plugin cannot be used w/o Maven. That's my assumption/understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401517072
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
seems we do use it, even if I don't quite see how. I took it out and tests failed:
[INFO]
[ERROR] Errors:
[ERROR] TestGetMojo.testRemoteRepositories:117 » MojoExecution Couldn't download artif...
[ERROR] TestGetMojo.testRemoteRepositoriesAuthentication:137 » MojoExecution Couldn't ...
[ERROR] TestGetMojo.testTransitive:96 » MojoExecution Couldn't download artifact: Fail...
[INFO]
[ERROR] Tests run: 250, Failures: 0, Errors: 3, Skipped: 0
[INFO]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401396538
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
Does this incur any class changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo merged pull request #43: update
dependencies
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401514650
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
In 3.3.4 this is three classes in org.apache.maven.wagon.providers.http
In 1.0-beta-6 this is two classes in the same package, so as best I can tell the answer is no.
I'm not 100% sure we need this dependency at all. We don't seem to import any of those, though it might get loaded though some sort of indirect service provider mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401515569
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
also, it's provided so at runtime this gets replaced anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull
request #43: update dependencies
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #43: update dependencies
URL: https://github.com/apache/maven-dependency-plugin/pull/43#discussion_r401522254
##########
File path: pom.xml
##########
@@ -316,7 +316,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
+ <version>3.3.4</version>
Review comment:
Maven core comes already with a provider. I bet this one is not necessary. Have you tried to remove it and run all ITs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services