You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Victoria Xia (Jira)" <ji...@apache.org> on 2021/10/01 18:24:00 UTC

[jira] [Commented] (KAFKA-13268) Add more integration tests for Table Table FK joins with repartitioning

    [ https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423390#comment-17423390 ] 

Victoria Xia commented on KAFKA-13268:
--------------------------------------

Hey [~guozhang] we've already got KTableKTableForeignKeyInnerJoinMultiIntegrationTest.java for testing foreign key joins with differing number of partitions on the source tables, and [https://github.com/apache/kafka/pull/11368] is adding coverage for source tables with custom partitioners. Is this the extent of the test coverage you had in mind with this ticket, or were you imagining something else? Thanks! 

> Add more integration tests for Table Table FK joins with repartitioning
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-13268
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13268
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: Guozhang Wang
>            Assignee: Victoria Xia
>            Priority: Major
>
> We should add to the FK join multipartition integration test with a Repartitioned for:
> 1) just the new partition count
> 2) a custom partitioner
> This is to test if there's a bug where the internal topics don't pick up a partitioner provided that way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)